You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/29 21:31:20 UTC
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
weizhouapache commented on a change in pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#discussion_r567104868
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java
##########
@@ -52,18 +52,33 @@ public Answer execute(final DeleteVMSnapshotCommand cmd, final LibvirtComputingR
final KVMStoragePoolManager storagePoolMgr = libvirtComputingResource.getStoragePoolMgr();
Domain dm = null;
DomainSnapshot snapshot = null;
+ DomainInfo.DomainState oldState = null;
Review comment:
@ggoodrich-ipp
should it be "DomainState" instead of "DomainInfo.DomainState" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org