[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on a change in pull request #15: AMQNET-596: Added local message expiry connection uri connection property

[GitBox <gi...@apache.org>]

cjwmorgan-sol commented on a change in pull request #15: AMQNET-596: Added local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15#discussion_r312969169
 
 

 ##########
 File path: src/NMS.AMQP/NmsConnectionFactory.cs
 ##########
 @@ -99,6 +99,11 @@ private IdGenerator ConnectionIdGenerator
             }
         }
 
+        /// <summary>
+        /// Enables local message expiry for all MessageConsumers under the connection. Default is true.
+        /// </summary>
+        public bool IsLocalMessageExpiry { get; set; } = true;
 
 Review comment:
   I will update the properties references. I think having IsLocalMessageExpiry is closer to the meta data interface qpid jms has. However, the uri property should be the same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services