You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/10/24 14:55:15 UTC
[41/51] [partial] hbase-site git commit: Published site at
3fe8649b2c9ba1271c25e8f476548907e4c7a90d.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/8f09a71d/devapidocs/src-html/org/apache/hadoop/hbase/master/HMaster.InitializationMonitor.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/HMaster.InitializationMonitor.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/HMaster.InitializationMonitor.html
index b7a2a38..6591d6c 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/HMaster.InitializationMonitor.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/HMaster.InitializationMonitor.html
@@ -1789,2174 +1789,2176 @@
<span class="sourceLineNo">1781</span> LOG.debug("Master has not been initialized, don't run region normalizer.");<a name="line.1781"></a>
<span class="sourceLineNo">1782</span> return false;<a name="line.1782"></a>
<span class="sourceLineNo">1783</span> }<a name="line.1783"></a>
-<span class="sourceLineNo">1784</span><a name="line.1784"></a>
-<span class="sourceLineNo">1785</span> if (isInMaintenanceMode()) {<a name="line.1785"></a>
-<span class="sourceLineNo">1786</span> LOG.info("Master is in maintenance mode, don't run region normalizer.");<a name="line.1786"></a>
-<span class="sourceLineNo">1787</span> return false;<a name="line.1787"></a>
-<span class="sourceLineNo">1788</span> }<a name="line.1788"></a>
-<span class="sourceLineNo">1789</span><a name="line.1789"></a>
-<span class="sourceLineNo">1790</span> if (!this.regionNormalizerTracker.isNormalizerOn()) {<a name="line.1790"></a>
-<span class="sourceLineNo">1791</span> LOG.debug("Region normalization is disabled, don't run region normalizer.");<a name="line.1791"></a>
-<span class="sourceLineNo">1792</span> return false;<a name="line.1792"></a>
-<span class="sourceLineNo">1793</span> }<a name="line.1793"></a>
-<span class="sourceLineNo">1794</span><a name="line.1794"></a>
-<span class="sourceLineNo">1795</span> synchronized (this.normalizer) {<a name="line.1795"></a>
-<span class="sourceLineNo">1796</span> // Don't run the normalizer concurrently<a name="line.1796"></a>
-<span class="sourceLineNo">1797</span> List<TableName> allEnabledTables = new ArrayList<>(<a name="line.1797"></a>
-<span class="sourceLineNo">1798</span> this.tableStateManager.getTablesInStates(TableState.State.ENABLED));<a name="line.1798"></a>
-<span class="sourceLineNo">1799</span><a name="line.1799"></a>
-<span class="sourceLineNo">1800</span> Collections.shuffle(allEnabledTables);<a name="line.1800"></a>
+<span class="sourceLineNo">1784</span> if (this.getServerManager().isClusterShutdown()) {<a name="line.1784"></a>
+<span class="sourceLineNo">1785</span> LOG.info("Cluster is shutting down, don't run region normalizer.");<a name="line.1785"></a>
+<span class="sourceLineNo">1786</span> return false;<a name="line.1786"></a>
+<span class="sourceLineNo">1787</span> }<a name="line.1787"></a>
+<span class="sourceLineNo">1788</span> if (isInMaintenanceMode()) {<a name="line.1788"></a>
+<span class="sourceLineNo">1789</span> LOG.info("Master is in maintenance mode, don't run region normalizer.");<a name="line.1789"></a>
+<span class="sourceLineNo">1790</span> return false;<a name="line.1790"></a>
+<span class="sourceLineNo">1791</span> }<a name="line.1791"></a>
+<span class="sourceLineNo">1792</span> if (!this.regionNormalizerTracker.isNormalizerOn()) {<a name="line.1792"></a>
+<span class="sourceLineNo">1793</span> LOG.debug("Region normalization is disabled, don't run region normalizer.");<a name="line.1793"></a>
+<span class="sourceLineNo">1794</span> return false;<a name="line.1794"></a>
+<span class="sourceLineNo">1795</span> }<a name="line.1795"></a>
+<span class="sourceLineNo">1796</span><a name="line.1796"></a>
+<span class="sourceLineNo">1797</span> synchronized (this.normalizer) {<a name="line.1797"></a>
+<span class="sourceLineNo">1798</span> // Don't run the normalizer concurrently<a name="line.1798"></a>
+<span class="sourceLineNo">1799</span> List<TableName> allEnabledTables = new ArrayList<>(<a name="line.1799"></a>
+<span class="sourceLineNo">1800</span> this.tableStateManager.getTablesInStates(TableState.State.ENABLED));<a name="line.1800"></a>
<span class="sourceLineNo">1801</span><a name="line.1801"></a>
-<span class="sourceLineNo">1802</span> for (TableName table : allEnabledTables) {<a name="line.1802"></a>
-<span class="sourceLineNo">1803</span> if (isInMaintenanceMode()) {<a name="line.1803"></a>
-<span class="sourceLineNo">1804</span> LOG.debug("Master is in maintenance mode, stop running region normalizer.");<a name="line.1804"></a>
-<span class="sourceLineNo">1805</span> return false;<a name="line.1805"></a>
-<span class="sourceLineNo">1806</span> }<a name="line.1806"></a>
-<span class="sourceLineNo">1807</span><a name="line.1807"></a>
-<span class="sourceLineNo">1808</span> TableDescriptor tblDesc = getTableDescriptors().get(table);<a name="line.1808"></a>
-<span class="sourceLineNo">1809</span> if (table.isSystemTable() || (tblDesc != null &&<a name="line.1809"></a>
-<span class="sourceLineNo">1810</span> !tblDesc.isNormalizationEnabled())) {<a name="line.1810"></a>
-<span class="sourceLineNo">1811</span> LOG.trace("Skipping normalization for {}, as it's either system"<a name="line.1811"></a>
-<span class="sourceLineNo">1812</span> + " table or doesn't have auto normalization turned on", table);<a name="line.1812"></a>
-<span class="sourceLineNo">1813</span> continue;<a name="line.1813"></a>
-<span class="sourceLineNo">1814</span> }<a name="line.1814"></a>
-<span class="sourceLineNo">1815</span> List<NormalizationPlan> plans = this.normalizer.computePlanForTable(table);<a name="line.1815"></a>
-<span class="sourceLineNo">1816</span> if (plans != null) {<a name="line.1816"></a>
-<span class="sourceLineNo">1817</span> for (NormalizationPlan plan : plans) {<a name="line.1817"></a>
-<span class="sourceLineNo">1818</span> plan.execute(clusterConnection.getAdmin());<a name="line.1818"></a>
-<span class="sourceLineNo">1819</span> if (plan.getType() == PlanType.SPLIT) {<a name="line.1819"></a>
-<span class="sourceLineNo">1820</span> splitPlanCount++;<a name="line.1820"></a>
-<span class="sourceLineNo">1821</span> } else if (plan.getType() == PlanType.MERGE) {<a name="line.1821"></a>
-<span class="sourceLineNo">1822</span> mergePlanCount++;<a name="line.1822"></a>
-<span class="sourceLineNo">1823</span> }<a name="line.1823"></a>
-<span class="sourceLineNo">1824</span> }<a name="line.1824"></a>
-<span class="sourceLineNo">1825</span> }<a name="line.1825"></a>
-<span class="sourceLineNo">1826</span> }<a name="line.1826"></a>
-<span class="sourceLineNo">1827</span> }<a name="line.1827"></a>
-<span class="sourceLineNo">1828</span> // If Region did not generate any plans, it means the cluster is already balanced.<a name="line.1828"></a>
-<span class="sourceLineNo">1829</span> // Return true indicating a success.<a name="line.1829"></a>
-<span class="sourceLineNo">1830</span> return true;<a name="line.1830"></a>
-<span class="sourceLineNo">1831</span> }<a name="line.1831"></a>
-<span class="sourceLineNo">1832</span><a name="line.1832"></a>
-<span class="sourceLineNo">1833</span> /**<a name="line.1833"></a>
-<span class="sourceLineNo">1834</span> * @return Client info for use as prefix on an audit log string; who did an action<a name="line.1834"></a>
-<span class="sourceLineNo">1835</span> */<a name="line.1835"></a>
-<span class="sourceLineNo">1836</span> @Override<a name="line.1836"></a>
-<span class="sourceLineNo">1837</span> public String getClientIdAuditPrefix() {<a name="line.1837"></a>
-<span class="sourceLineNo">1838</span> return "Client=" + RpcServer.getRequestUserName().orElse(null)<a name="line.1838"></a>
-<span class="sourceLineNo">1839</span> + "/" + RpcServer.getRemoteAddress().orElse(null);<a name="line.1839"></a>
-<span class="sourceLineNo">1840</span> }<a name="line.1840"></a>
-<span class="sourceLineNo">1841</span><a name="line.1841"></a>
-<span class="sourceLineNo">1842</span> /**<a name="line.1842"></a>
-<span class="sourceLineNo">1843</span> * Switch for the background CatalogJanitor thread.<a name="line.1843"></a>
-<span class="sourceLineNo">1844</span> * Used for testing. The thread will continue to run. It will just be a noop<a name="line.1844"></a>
-<span class="sourceLineNo">1845</span> * if disabled.<a name="line.1845"></a>
-<span class="sourceLineNo">1846</span> * @param b If false, the catalog janitor won't do anything.<a name="line.1846"></a>
-<span class="sourceLineNo">1847</span> */<a name="line.1847"></a>
-<span class="sourceLineNo">1848</span> public void setCatalogJanitorEnabled(final boolean b) {<a name="line.1848"></a>
-<span class="sourceLineNo">1849</span> this.catalogJanitorChore.setEnabled(b);<a name="line.1849"></a>
-<span class="sourceLineNo">1850</span> }<a name="line.1850"></a>
-<span class="sourceLineNo">1851</span><a name="line.1851"></a>
-<span class="sourceLineNo">1852</span> @Override<a name="line.1852"></a>
-<span class="sourceLineNo">1853</span> public long mergeRegions(<a name="line.1853"></a>
-<span class="sourceLineNo">1854</span> final RegionInfo[] regionsToMerge,<a name="line.1854"></a>
-<span class="sourceLineNo">1855</span> final boolean forcible,<a name="line.1855"></a>
-<span class="sourceLineNo">1856</span> final long nonceGroup,<a name="line.1856"></a>
-<span class="sourceLineNo">1857</span> final long nonce) throws IOException {<a name="line.1857"></a>
-<span class="sourceLineNo">1858</span> checkInitialized();<a name="line.1858"></a>
-<span class="sourceLineNo">1859</span><a name="line.1859"></a>
-<span class="sourceLineNo">1860</span> assert(regionsToMerge.length == 2);<a name="line.1860"></a>
+<span class="sourceLineNo">1802</span> Collections.shuffle(allEnabledTables);<a name="line.1802"></a>
+<span class="sourceLineNo">1803</span><a name="line.1803"></a>
+<span class="sourceLineNo">1804</span> for (TableName table : allEnabledTables) {<a name="line.1804"></a>
+<span class="sourceLineNo">1805</span> if (isInMaintenanceMode()) {<a name="line.1805"></a>
+<span class="sourceLineNo">1806</span> LOG.debug("Master is in maintenance mode, stop running region normalizer.");<a name="line.1806"></a>
+<span class="sourceLineNo">1807</span> return false;<a name="line.1807"></a>
+<span class="sourceLineNo">1808</span> }<a name="line.1808"></a>
+<span class="sourceLineNo">1809</span><a name="line.1809"></a>
+<span class="sourceLineNo">1810</span> TableDescriptor tblDesc = getTableDescriptors().get(table);<a name="line.1810"></a>
+<span class="sourceLineNo">1811</span> if (table.isSystemTable() || (tblDesc != null &&<a name="line.1811"></a>
+<span class="sourceLineNo">1812</span> !tblDesc.isNormalizationEnabled())) {<a name="line.1812"></a>
+<span class="sourceLineNo">1813</span> LOG.trace("Skipping normalization for {}, as it's either system"<a name="line.1813"></a>
+<span class="sourceLineNo">1814</span> + " table or doesn't have auto normalization turned on", table);<a name="line.1814"></a>
+<span class="sourceLineNo">1815</span> continue;<a name="line.1815"></a>
+<span class="sourceLineNo">1816</span> }<a name="line.1816"></a>
+<span class="sourceLineNo">1817</span> List<NormalizationPlan> plans = this.normalizer.computePlanForTable(table);<a name="line.1817"></a>
+<span class="sourceLineNo">1818</span> if (plans != null) {<a name="line.1818"></a>
+<span class="sourceLineNo">1819</span> for (NormalizationPlan plan : plans) {<a name="line.1819"></a>
+<span class="sourceLineNo">1820</span> plan.execute(clusterConnection.getAdmin());<a name="line.1820"></a>
+<span class="sourceLineNo">1821</span> if (plan.getType() == PlanType.SPLIT) {<a name="line.1821"></a>
+<span class="sourceLineNo">1822</span> splitPlanCount++;<a name="line.1822"></a>
+<span class="sourceLineNo">1823</span> } else if (plan.getType() == PlanType.MERGE) {<a name="line.1823"></a>
+<span class="sourceLineNo">1824</span> mergePlanCount++;<a name="line.1824"></a>
+<span class="sourceLineNo">1825</span> }<a name="line.1825"></a>
+<span class="sourceLineNo">1826</span> }<a name="line.1826"></a>
+<span class="sourceLineNo">1827</span> }<a name="line.1827"></a>
+<span class="sourceLineNo">1828</span> }<a name="line.1828"></a>
+<span class="sourceLineNo">1829</span> }<a name="line.1829"></a>
+<span class="sourceLineNo">1830</span> // If Region did not generate any plans, it means the cluster is already balanced.<a name="line.1830"></a>
+<span class="sourceLineNo">1831</span> // Return true indicating a success.<a name="line.1831"></a>
+<span class="sourceLineNo">1832</span> return true;<a name="line.1832"></a>
+<span class="sourceLineNo">1833</span> }<a name="line.1833"></a>
+<span class="sourceLineNo">1834</span><a name="line.1834"></a>
+<span class="sourceLineNo">1835</span> /**<a name="line.1835"></a>
+<span class="sourceLineNo">1836</span> * @return Client info for use as prefix on an audit log string; who did an action<a name="line.1836"></a>
+<span class="sourceLineNo">1837</span> */<a name="line.1837"></a>
+<span class="sourceLineNo">1838</span> @Override<a name="line.1838"></a>
+<span class="sourceLineNo">1839</span> public String getClientIdAuditPrefix() {<a name="line.1839"></a>
+<span class="sourceLineNo">1840</span> return "Client=" + RpcServer.getRequestUserName().orElse(null)<a name="line.1840"></a>
+<span class="sourceLineNo">1841</span> + "/" + RpcServer.getRemoteAddress().orElse(null);<a name="line.1841"></a>
+<span class="sourceLineNo">1842</span> }<a name="line.1842"></a>
+<span class="sourceLineNo">1843</span><a name="line.1843"></a>
+<span class="sourceLineNo">1844</span> /**<a name="line.1844"></a>
+<span class="sourceLineNo">1845</span> * Switch for the background CatalogJanitor thread.<a name="line.1845"></a>
+<span class="sourceLineNo">1846</span> * Used for testing. The thread will continue to run. It will just be a noop<a name="line.1846"></a>
+<span class="sourceLineNo">1847</span> * if disabled.<a name="line.1847"></a>
+<span class="sourceLineNo">1848</span> * @param b If false, the catalog janitor won't do anything.<a name="line.1848"></a>
+<span class="sourceLineNo">1849</span> */<a name="line.1849"></a>
+<span class="sourceLineNo">1850</span> public void setCatalogJanitorEnabled(final boolean b) {<a name="line.1850"></a>
+<span class="sourceLineNo">1851</span> this.catalogJanitorChore.setEnabled(b);<a name="line.1851"></a>
+<span class="sourceLineNo">1852</span> }<a name="line.1852"></a>
+<span class="sourceLineNo">1853</span><a name="line.1853"></a>
+<span class="sourceLineNo">1854</span> @Override<a name="line.1854"></a>
+<span class="sourceLineNo">1855</span> public long mergeRegions(<a name="line.1855"></a>
+<span class="sourceLineNo">1856</span> final RegionInfo[] regionsToMerge,<a name="line.1856"></a>
+<span class="sourceLineNo">1857</span> final boolean forcible,<a name="line.1857"></a>
+<span class="sourceLineNo">1858</span> final long nonceGroup,<a name="line.1858"></a>
+<span class="sourceLineNo">1859</span> final long nonce) throws IOException {<a name="line.1859"></a>
+<span class="sourceLineNo">1860</span> checkInitialized();<a name="line.1860"></a>
<span class="sourceLineNo">1861</span><a name="line.1861"></a>
-<span class="sourceLineNo">1862</span> TableName tableName = regionsToMerge[0].getTable();<a name="line.1862"></a>
-<span class="sourceLineNo">1863</span> if (tableName == null || regionsToMerge[1].getTable() == null) {<a name="line.1863"></a>
-<span class="sourceLineNo">1864</span> throw new UnknownRegionException ("Can't merge regions without table associated");<a name="line.1864"></a>
-<span class="sourceLineNo">1865</span> }<a name="line.1865"></a>
-<span class="sourceLineNo">1866</span><a name="line.1866"></a>
-<span class="sourceLineNo">1867</span> if (!tableName.equals(regionsToMerge[1].getTable())) {<a name="line.1867"></a>
-<span class="sourceLineNo">1868</span> throw new IOException (<a name="line.1868"></a>
-<span class="sourceLineNo">1869</span> "Cannot merge regions from two different tables " + regionsToMerge[0].getTable()<a name="line.1869"></a>
-<span class="sourceLineNo">1870</span> + " and " + regionsToMerge[1].getTable());<a name="line.1870"></a>
-<span class="sourceLineNo">1871</span> }<a name="line.1871"></a>
-<span class="sourceLineNo">1872</span><a name="line.1872"></a>
-<span class="sourceLineNo">1873</span> if (RegionInfo.COMPARATOR.compare(regionsToMerge[0], regionsToMerge[1]) == 0) {<a name="line.1873"></a>
-<span class="sourceLineNo">1874</span> throw new MergeRegionException(<a name="line.1874"></a>
-<span class="sourceLineNo">1875</span> "Cannot merge a region to itself " + regionsToMerge[0] + ", " + regionsToMerge[1]);<a name="line.1875"></a>
-<span class="sourceLineNo">1876</span> }<a name="line.1876"></a>
-<span class="sourceLineNo">1877</span><a name="line.1877"></a>
-<span class="sourceLineNo">1878</span> return MasterProcedureUtil.submitProcedure(<a name="line.1878"></a>
-<span class="sourceLineNo">1879</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.1879"></a>
-<span class="sourceLineNo">1880</span> @Override<a name="line.1880"></a>
-<span class="sourceLineNo">1881</span> protected void run() throws IOException {<a name="line.1881"></a>
-<span class="sourceLineNo">1882</span> getMaster().getMasterCoprocessorHost().preMergeRegions(regionsToMerge);<a name="line.1882"></a>
-<span class="sourceLineNo">1883</span><a name="line.1883"></a>
-<span class="sourceLineNo">1884</span> LOG.info(getClientIdAuditPrefix() + " Merge regions " +<a name="line.1884"></a>
-<span class="sourceLineNo">1885</span> regionsToMerge[0].getEncodedName() + " and " + regionsToMerge[1].getEncodedName());<a name="line.1885"></a>
-<span class="sourceLineNo">1886</span><a name="line.1886"></a>
-<span class="sourceLineNo">1887</span> submitProcedure(new MergeTableRegionsProcedure(procedureExecutor.getEnvironment(),<a name="line.1887"></a>
-<span class="sourceLineNo">1888</span> regionsToMerge, forcible));<a name="line.1888"></a>
-<span class="sourceLineNo">1889</span><a name="line.1889"></a>
-<span class="sourceLineNo">1890</span> getMaster().getMasterCoprocessorHost().postMergeRegions(regionsToMerge);<a name="line.1890"></a>
-<span class="sourceLineNo">1891</span> }<a name="line.1891"></a>
-<span class="sourceLineNo">1892</span><a name="line.1892"></a>
-<span class="sourceLineNo">1893</span> @Override<a name="line.1893"></a>
-<span class="sourceLineNo">1894</span> protected String getDescription() {<a name="line.1894"></a>
-<span class="sourceLineNo">1895</span> return "MergeTableProcedure";<a name="line.1895"></a>
-<span class="sourceLineNo">1896</span> }<a name="line.1896"></a>
-<span class="sourceLineNo">1897</span> });<a name="line.1897"></a>
-<span class="sourceLineNo">1898</span> }<a name="line.1898"></a>
-<span class="sourceLineNo">1899</span><a name="line.1899"></a>
-<span class="sourceLineNo">1900</span> @Override<a name="line.1900"></a>
-<span class="sourceLineNo">1901</span> public long splitRegion(final RegionInfo regionInfo, final byte[] splitRow,<a name="line.1901"></a>
-<span class="sourceLineNo">1902</span> final long nonceGroup, final long nonce)<a name="line.1902"></a>
-<span class="sourceLineNo">1903</span> throws IOException {<a name="line.1903"></a>
-<span class="sourceLineNo">1904</span> checkInitialized();<a name="line.1904"></a>
-<span class="sourceLineNo">1905</span> return MasterProcedureUtil.submitProcedure(<a name="line.1905"></a>
-<span class="sourceLineNo">1906</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.1906"></a>
-<span class="sourceLineNo">1907</span> @Override<a name="line.1907"></a>
-<span class="sourceLineNo">1908</span> protected void run() throws IOException {<a name="line.1908"></a>
-<span class="sourceLineNo">1909</span> getMaster().getMasterCoprocessorHost().preSplitRegion(regionInfo.getTable(), splitRow);<a name="line.1909"></a>
-<span class="sourceLineNo">1910</span> LOG.info(getClientIdAuditPrefix() + " split " + regionInfo.getRegionNameAsString());<a name="line.1910"></a>
-<span class="sourceLineNo">1911</span><a name="line.1911"></a>
-<span class="sourceLineNo">1912</span> // Execute the operation asynchronously<a name="line.1912"></a>
-<span class="sourceLineNo">1913</span> submitProcedure(getAssignmentManager().createSplitProcedure(regionInfo, splitRow));<a name="line.1913"></a>
-<span class="sourceLineNo">1914</span> }<a name="line.1914"></a>
-<span class="sourceLineNo">1915</span><a name="line.1915"></a>
-<span class="sourceLineNo">1916</span> @Override<a name="line.1916"></a>
-<span class="sourceLineNo">1917</span> protected String getDescription() {<a name="line.1917"></a>
-<span class="sourceLineNo">1918</span> return "SplitTableProcedure";<a name="line.1918"></a>
-<span class="sourceLineNo">1919</span> }<a name="line.1919"></a>
-<span class="sourceLineNo">1920</span> });<a name="line.1920"></a>
-<span class="sourceLineNo">1921</span> }<a name="line.1921"></a>
-<span class="sourceLineNo">1922</span><a name="line.1922"></a>
-<span class="sourceLineNo">1923</span> // Public so can be accessed by tests. Blocks until move is done.<a name="line.1923"></a>
-<span class="sourceLineNo">1924</span> // Replace with an async implementation from which you can get<a name="line.1924"></a>
-<span class="sourceLineNo">1925</span> // a success/failure result.<a name="line.1925"></a>
-<span class="sourceLineNo">1926</span> @VisibleForTesting<a name="line.1926"></a>
-<span class="sourceLineNo">1927</span> public void move(final byte[] encodedRegionName, byte[] destServerName) throws HBaseIOException {<a name="line.1927"></a>
-<span class="sourceLineNo">1928</span> RegionState regionState = assignmentManager.getRegionStates().<a name="line.1928"></a>
-<span class="sourceLineNo">1929</span> getRegionState(Bytes.toString(encodedRegionName));<a name="line.1929"></a>
-<span class="sourceLineNo">1930</span><a name="line.1930"></a>
-<span class="sourceLineNo">1931</span> RegionInfo hri;<a name="line.1931"></a>
-<span class="sourceLineNo">1932</span> if (regionState != null) {<a name="line.1932"></a>
-<span class="sourceLineNo">1933</span> hri = regionState.getRegion();<a name="line.1933"></a>
-<span class="sourceLineNo">1934</span> } else {<a name="line.1934"></a>
-<span class="sourceLineNo">1935</span> throw new UnknownRegionException(Bytes.toStringBinary(encodedRegionName));<a name="line.1935"></a>
-<span class="sourceLineNo">1936</span> }<a name="line.1936"></a>
-<span class="sourceLineNo">1937</span><a name="line.1937"></a>
-<span class="sourceLineNo">1938</span> ServerName dest;<a name="line.1938"></a>
-<span class="sourceLineNo">1939</span> List<ServerName> exclude = hri.getTable().isSystemTable() ? assignmentManager.getExcludedServersForSystemTable()<a name="line.1939"></a>
-<span class="sourceLineNo">1940</span> : new ArrayList<>(1);<a name="line.1940"></a>
-<span class="sourceLineNo">1941</span> if (destServerName != null && exclude.contains(ServerName.valueOf(Bytes.toString(destServerName)))) {<a name="line.1941"></a>
-<span class="sourceLineNo">1942</span> LOG.info(<a name="line.1942"></a>
-<span class="sourceLineNo">1943</span> Bytes.toString(encodedRegionName) + " can not move to " + Bytes.toString(destServerName)<a name="line.1943"></a>
-<span class="sourceLineNo">1944</span> + " because the server is in exclude list");<a name="line.1944"></a>
-<span class="sourceLineNo">1945</span> destServerName = null;<a name="line.1945"></a>
-<span class="sourceLineNo">1946</span> }<a name="line.1946"></a>
-<span class="sourceLineNo">1947</span> if (destServerName == null || destServerName.length == 0) {<a name="line.1947"></a>
-<span class="sourceLineNo">1948</span> LOG.info("Passed destination servername is null/empty so " +<a name="line.1948"></a>
-<span class="sourceLineNo">1949</span> "choosing a server at random");<a name="line.1949"></a>
-<span class="sourceLineNo">1950</span> exclude.add(regionState.getServerName());<a name="line.1950"></a>
-<span class="sourceLineNo">1951</span> final List<ServerName> destServers = this.serverManager.createDestinationServersList(exclude);<a name="line.1951"></a>
-<span class="sourceLineNo">1952</span> dest = balancer.randomAssignment(hri, destServers);<a name="line.1952"></a>
-<span class="sourceLineNo">1953</span> if (dest == null) {<a name="line.1953"></a>
-<span class="sourceLineNo">1954</span> LOG.debug("Unable to determine a plan to assign " + hri);<a name="line.1954"></a>
-<span class="sourceLineNo">1955</span> return;<a name="line.1955"></a>
-<span class="sourceLineNo">1956</span> }<a name="line.1956"></a>
-<span class="sourceLineNo">1957</span> } else {<a name="line.1957"></a>
-<span class="sourceLineNo">1958</span> ServerName candidate = ServerName.valueOf(Bytes.toString(destServerName));<a name="line.1958"></a>
-<span class="sourceLineNo">1959</span> dest = balancer.randomAssignment(hri, Lists.newArrayList(candidate));<a name="line.1959"></a>
-<span class="sourceLineNo">1960</span> if (dest == null) {<a name="line.1960"></a>
-<span class="sourceLineNo">1961</span> LOG.debug("Unable to determine a plan to assign " + hri);<a name="line.1961"></a>
-<span class="sourceLineNo">1962</span> return;<a name="line.1962"></a>
-<span class="sourceLineNo">1963</span> }<a name="line.1963"></a>
-<span class="sourceLineNo">1964</span> // TODO: What is this? I don't get it.<a name="line.1964"></a>
-<span class="sourceLineNo">1965</span> if (dest.equals(serverName) && balancer instanceof BaseLoadBalancer<a name="line.1965"></a>
-<span class="sourceLineNo">1966</span> && !((BaseLoadBalancer)balancer).shouldBeOnMaster(hri)) {<a name="line.1966"></a>
-<span class="sourceLineNo">1967</span> // To avoid unnecessary region moving later by balancer. Don't put user<a name="line.1967"></a>
-<span class="sourceLineNo">1968</span> // regions on master.<a name="line.1968"></a>
-<span class="sourceLineNo">1969</span> LOG.debug("Skipping move of region " + hri.getRegionNameAsString()<a name="line.1969"></a>
-<span class="sourceLineNo">1970</span> + " to avoid unnecessary region moving later by load balancer,"<a name="line.1970"></a>
-<span class="sourceLineNo">1971</span> + " because it should not be on master");<a name="line.1971"></a>
-<span class="sourceLineNo">1972</span> return;<a name="line.1972"></a>
-<span class="sourceLineNo">1973</span> }<a name="line.1973"></a>
-<span class="sourceLineNo">1974</span> }<a name="line.1974"></a>
-<span class="sourceLineNo">1975</span><a name="line.1975"></a>
-<span class="sourceLineNo">1976</span> if (dest.equals(regionState.getServerName())) {<a name="line.1976"></a>
-<span class="sourceLineNo">1977</span> LOG.debug("Skipping move of region " + hri.getRegionNameAsString()<a name="line.1977"></a>
-<span class="sourceLineNo">1978</span> + " because region already assigned to the same server " + dest + ".");<a name="line.1978"></a>
-<span class="sourceLineNo">1979</span> return;<a name="line.1979"></a>
-<span class="sourceLineNo">1980</span> }<a name="line.1980"></a>
-<span class="sourceLineNo">1981</span><a name="line.1981"></a>
-<span class="sourceLineNo">1982</span> // Now we can do the move<a name="line.1982"></a>
-<span class="sourceLineNo">1983</span> RegionPlan rp = new RegionPlan(hri, regionState.getServerName(), dest);<a name="line.1983"></a>
-<span class="sourceLineNo">1984</span> assert rp.getDestination() != null: rp.toString() + " " + dest;<a name="line.1984"></a>
-<span class="sourceLineNo">1985</span><a name="line.1985"></a>
-<span class="sourceLineNo">1986</span> try {<a name="line.1986"></a>
-<span class="sourceLineNo">1987</span> checkInitialized();<a name="line.1987"></a>
-<span class="sourceLineNo">1988</span> if (this.cpHost != null) {<a name="line.1988"></a>
-<span class="sourceLineNo">1989</span> this.cpHost.preMove(hri, rp.getSource(), rp.getDestination());<a name="line.1989"></a>
-<span class="sourceLineNo">1990</span> }<a name="line.1990"></a>
-<span class="sourceLineNo">1991</span> // Warmup the region on the destination before initiating the move. this call<a name="line.1991"></a>
-<span class="sourceLineNo">1992</span> // is synchronous and takes some time. doing it before the source region gets<a name="line.1992"></a>
-<span class="sourceLineNo">1993</span> // closed<a name="line.1993"></a>
-<span class="sourceLineNo">1994</span> serverManager.sendRegionWarmup(rp.getDestination(), hri);<a name="line.1994"></a>
-<span class="sourceLineNo">1995</span><a name="line.1995"></a>
-<span class="sourceLineNo">1996</span> LOG.info(getClientIdAuditPrefix() + " move " + rp + ", running balancer");<a name="line.1996"></a>
-<span class="sourceLineNo">1997</span> Future<byte []> future = this.assignmentManager.moveAsync(rp);<a name="line.1997"></a>
-<span class="sourceLineNo">1998</span> try {<a name="line.1998"></a>
-<span class="sourceLineNo">1999</span> // Is this going to work? Will we throw exception on error?<a name="line.1999"></a>
-<span class="sourceLineNo">2000</span> // TODO: CompletableFuture rather than this stunted Future.<a name="line.2000"></a>
-<span class="sourceLineNo">2001</span> future.get();<a name="line.2001"></a>
-<span class="sourceLineNo">2002</span> } catch (InterruptedException | ExecutionException e) {<a name="line.2002"></a>
-<span class="sourceLineNo">2003</span> throw new HBaseIOException(e);<a name="line.2003"></a>
-<span class="sourceLineNo">2004</span> }<a name="line.2004"></a>
-<span class="sourceLineNo">2005</span> if (this.cpHost != null) {<a name="line.2005"></a>
-<span class="sourceLineNo">2006</span> this.cpHost.postMove(hri, rp.getSource(), rp.getDestination());<a name="line.2006"></a>
-<span class="sourceLineNo">2007</span> }<a name="line.2007"></a>
-<span class="sourceLineNo">2008</span> } catch (IOException ioe) {<a name="line.2008"></a>
-<span class="sourceLineNo">2009</span> if (ioe instanceof HBaseIOException) {<a name="line.2009"></a>
-<span class="sourceLineNo">2010</span> throw (HBaseIOException)ioe;<a name="line.2010"></a>
-<span class="sourceLineNo">2011</span> }<a name="line.2011"></a>
-<span class="sourceLineNo">2012</span> throw new HBaseIOException(ioe);<a name="line.2012"></a>
-<span class="sourceLineNo">2013</span> }<a name="line.2013"></a>
-<span class="sourceLineNo">2014</span> }<a name="line.2014"></a>
-<span class="sourceLineNo">2015</span><a name="line.2015"></a>
-<span class="sourceLineNo">2016</span> @Override<a name="line.2016"></a>
-<span class="sourceLineNo">2017</span> public long createTable(<a name="line.2017"></a>
-<span class="sourceLineNo">2018</span> final TableDescriptor tableDescriptor,<a name="line.2018"></a>
-<span class="sourceLineNo">2019</span> final byte [][] splitKeys,<a name="line.2019"></a>
-<span class="sourceLineNo">2020</span> final long nonceGroup,<a name="line.2020"></a>
-<span class="sourceLineNo">2021</span> final long nonce) throws IOException {<a name="line.2021"></a>
-<span class="sourceLineNo">2022</span> checkInitialized();<a name="line.2022"></a>
-<span class="sourceLineNo">2023</span><a name="line.2023"></a>
-<span class="sourceLineNo">2024</span> String namespace = tableDescriptor.getTableName().getNamespaceAsString();<a name="line.2024"></a>
-<span class="sourceLineNo">2025</span> this.clusterSchemaService.getNamespace(namespace);<a name="line.2025"></a>
-<span class="sourceLineNo">2026</span><a name="line.2026"></a>
-<span class="sourceLineNo">2027</span> RegionInfo[] newRegions = ModifyRegionUtils.createRegionInfos(tableDescriptor, splitKeys);<a name="line.2027"></a>
-<span class="sourceLineNo">2028</span> sanityCheckTableDescriptor(tableDescriptor);<a name="line.2028"></a>
-<span class="sourceLineNo">2029</span><a name="line.2029"></a>
-<span class="sourceLineNo">2030</span> return MasterProcedureUtil.submitProcedure(<a name="line.2030"></a>
-<span class="sourceLineNo">2031</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.2031"></a>
-<span class="sourceLineNo">2032</span> @Override<a name="line.2032"></a>
-<span class="sourceLineNo">2033</span> protected void run() throws IOException {<a name="line.2033"></a>
-<span class="sourceLineNo">2034</span> getMaster().getMasterCoprocessorHost().preCreateTable(tableDescriptor, newRegions);<a name="line.2034"></a>
-<span class="sourceLineNo">2035</span><a name="line.2035"></a>
-<span class="sourceLineNo">2036</span> LOG.info(getClientIdAuditPrefix() + " create " + tableDescriptor);<a name="line.2036"></a>
+<span class="sourceLineNo">1862</span> assert(regionsToMerge.length == 2);<a name="line.1862"></a>
+<span class="sourceLineNo">1863</span><a name="line.1863"></a>
+<span class="sourceLineNo">1864</span> TableName tableName = regionsToMerge[0].getTable();<a name="line.1864"></a>
+<span class="sourceLineNo">1865</span> if (tableName == null || regionsToMerge[1].getTable() == null) {<a name="line.1865"></a>
+<span class="sourceLineNo">1866</span> throw new UnknownRegionException ("Can't merge regions without table associated");<a name="line.1866"></a>
+<span class="sourceLineNo">1867</span> }<a name="line.1867"></a>
+<span class="sourceLineNo">1868</span><a name="line.1868"></a>
+<span class="sourceLineNo">1869</span> if (!tableName.equals(regionsToMerge[1].getTable())) {<a name="line.1869"></a>
+<span class="sourceLineNo">1870</span> throw new IOException (<a name="line.1870"></a>
+<span class="sourceLineNo">1871</span> "Cannot merge regions from two different tables " + regionsToMerge[0].getTable()<a name="line.1871"></a>
+<span class="sourceLineNo">1872</span> + " and " + regionsToMerge[1].getTable());<a name="line.1872"></a>
+<span class="sourceLineNo">1873</span> }<a name="line.1873"></a>
+<span class="sourceLineNo">1874</span><a name="line.1874"></a>
+<span class="sourceLineNo">1875</span> if (RegionInfo.COMPARATOR.compare(regionsToMerge[0], regionsToMerge[1]) == 0) {<a name="line.1875"></a>
+<span class="sourceLineNo">1876</span> throw new MergeRegionException(<a name="line.1876"></a>
+<span class="sourceLineNo">1877</span> "Cannot merge a region to itself " + regionsToMerge[0] + ", " + regionsToMerge[1]);<a name="line.1877"></a>
+<span class="sourceLineNo">1878</span> }<a name="line.1878"></a>
+<span class="sourceLineNo">1879</span><a name="line.1879"></a>
+<span class="sourceLineNo">1880</span> return MasterProcedureUtil.submitProcedure(<a name="line.1880"></a>
+<span class="sourceLineNo">1881</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.1881"></a>
+<span class="sourceLineNo">1882</span> @Override<a name="line.1882"></a>
+<span class="sourceLineNo">1883</span> protected void run() throws IOException {<a name="line.1883"></a>
+<span class="sourceLineNo">1884</span> getMaster().getMasterCoprocessorHost().preMergeRegions(regionsToMerge);<a name="line.1884"></a>
+<span class="sourceLineNo">1885</span><a name="line.1885"></a>
+<span class="sourceLineNo">1886</span> LOG.info(getClientIdAuditPrefix() + " Merge regions " +<a name="line.1886"></a>
+<span class="sourceLineNo">1887</span> regionsToMerge[0].getEncodedName() + " and " + regionsToMerge[1].getEncodedName());<a name="line.1887"></a>
+<span class="sourceLineNo">1888</span><a name="line.1888"></a>
+<span class="sourceLineNo">1889</span> submitProcedure(new MergeTableRegionsProcedure(procedureExecutor.getEnvironment(),<a name="line.1889"></a>
+<span class="sourceLineNo">1890</span> regionsToMerge, forcible));<a name="line.1890"></a>
+<span class="sourceLineNo">1891</span><a name="line.1891"></a>
+<span class="sourceLineNo">1892</span> getMaster().getMasterCoprocessorHost().postMergeRegions(regionsToMerge);<a name="line.1892"></a>
+<span class="sourceLineNo">1893</span> }<a name="line.1893"></a>
+<span class="sourceLineNo">1894</span><a name="line.1894"></a>
+<span class="sourceLineNo">1895</span> @Override<a name="line.1895"></a>
+<span class="sourceLineNo">1896</span> protected String getDescription() {<a name="line.1896"></a>
+<span class="sourceLineNo">1897</span> return "MergeTableProcedure";<a name="line.1897"></a>
+<span class="sourceLineNo">1898</span> }<a name="line.1898"></a>
+<span class="sourceLineNo">1899</span> });<a name="line.1899"></a>
+<span class="sourceLineNo">1900</span> }<a name="line.1900"></a>
+<span class="sourceLineNo">1901</span><a name="line.1901"></a>
+<span class="sourceLineNo">1902</span> @Override<a name="line.1902"></a>
+<span class="sourceLineNo">1903</span> public long splitRegion(final RegionInfo regionInfo, final byte[] splitRow,<a name="line.1903"></a>
+<span class="sourceLineNo">1904</span> final long nonceGroup, final long nonce)<a name="line.1904"></a>
+<span class="sourceLineNo">1905</span> throws IOException {<a name="line.1905"></a>
+<span class="sourceLineNo">1906</span> checkInitialized();<a name="line.1906"></a>
+<span class="sourceLineNo">1907</span> return MasterProcedureUtil.submitProcedure(<a name="line.1907"></a>
+<span class="sourceLineNo">1908</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.1908"></a>
+<span class="sourceLineNo">1909</span> @Override<a name="line.1909"></a>
+<span class="sourceLineNo">1910</span> protected void run() throws IOException {<a name="line.1910"></a>
+<span class="sourceLineNo">1911</span> getMaster().getMasterCoprocessorHost().preSplitRegion(regionInfo.getTable(), splitRow);<a name="line.1911"></a>
+<span class="sourceLineNo">1912</span> LOG.info(getClientIdAuditPrefix() + " split " + regionInfo.getRegionNameAsString());<a name="line.1912"></a>
+<span class="sourceLineNo">1913</span><a name="line.1913"></a>
+<span class="sourceLineNo">1914</span> // Execute the operation asynchronously<a name="line.1914"></a>
+<span class="sourceLineNo">1915</span> submitProcedure(getAssignmentManager().createSplitProcedure(regionInfo, splitRow));<a name="line.1915"></a>
+<span class="sourceLineNo">1916</span> }<a name="line.1916"></a>
+<span class="sourceLineNo">1917</span><a name="line.1917"></a>
+<span class="sourceLineNo">1918</span> @Override<a name="line.1918"></a>
+<span class="sourceLineNo">1919</span> protected String getDescription() {<a name="line.1919"></a>
+<span class="sourceLineNo">1920</span> return "SplitTableProcedure";<a name="line.1920"></a>
+<span class="sourceLineNo">1921</span> }<a name="line.1921"></a>
+<span class="sourceLineNo">1922</span> });<a name="line.1922"></a>
+<span class="sourceLineNo">1923</span> }<a name="line.1923"></a>
+<span class="sourceLineNo">1924</span><a name="line.1924"></a>
+<span class="sourceLineNo">1925</span> // Public so can be accessed by tests. Blocks until move is done.<a name="line.1925"></a>
+<span class="sourceLineNo">1926</span> // Replace with an async implementation from which you can get<a name="line.1926"></a>
+<span class="sourceLineNo">1927</span> // a success/failure result.<a name="line.1927"></a>
+<span class="sourceLineNo">1928</span> @VisibleForTesting<a name="line.1928"></a>
+<span class="sourceLineNo">1929</span> public void move(final byte[] encodedRegionName, byte[] destServerName) throws HBaseIOException {<a name="line.1929"></a>
+<span class="sourceLineNo">1930</span> RegionState regionState = assignmentManager.getRegionStates().<a name="line.1930"></a>
+<span class="sourceLineNo">1931</span> getRegionState(Bytes.toString(encodedRegionName));<a name="line.1931"></a>
+<span class="sourceLineNo">1932</span><a name="line.1932"></a>
+<span class="sourceLineNo">1933</span> RegionInfo hri;<a name="line.1933"></a>
+<span class="sourceLineNo">1934</span> if (regionState != null) {<a name="line.1934"></a>
+<span class="sourceLineNo">1935</span> hri = regionState.getRegion();<a name="line.1935"></a>
+<span class="sourceLineNo">1936</span> } else {<a name="line.1936"></a>
+<span class="sourceLineNo">1937</span> throw new UnknownRegionException(Bytes.toStringBinary(encodedRegionName));<a name="line.1937"></a>
+<span class="sourceLineNo">1938</span> }<a name="line.1938"></a>
+<span class="sourceLineNo">1939</span><a name="line.1939"></a>
+<span class="sourceLineNo">1940</span> ServerName dest;<a name="line.1940"></a>
+<span class="sourceLineNo">1941</span> List<ServerName> exclude = hri.getTable().isSystemTable() ? assignmentManager.getExcludedServersForSystemTable()<a name="line.1941"></a>
+<span class="sourceLineNo">1942</span> : new ArrayList<>(1);<a name="line.1942"></a>
+<span class="sourceLineNo">1943</span> if (destServerName != null && exclude.contains(ServerName.valueOf(Bytes.toString(destServerName)))) {<a name="line.1943"></a>
+<span class="sourceLineNo">1944</span> LOG.info(<a name="line.1944"></a>
+<span class="sourceLineNo">1945</span> Bytes.toString(encodedRegionName) + " can not move to " + Bytes.toString(destServerName)<a name="line.1945"></a>
+<span class="sourceLineNo">1946</span> + " because the server is in exclude list");<a name="line.1946"></a>
+<span class="sourceLineNo">1947</span> destServerName = null;<a name="line.1947"></a>
+<span class="sourceLineNo">1948</span> }<a name="line.1948"></a>
+<span class="sourceLineNo">1949</span> if (destServerName == null || destServerName.length == 0) {<a name="line.1949"></a>
+<span class="sourceLineNo">1950</span> LOG.info("Passed destination servername is null/empty so " +<a name="line.1950"></a>
+<span class="sourceLineNo">1951</span> "choosing a server at random");<a name="line.1951"></a>
+<span class="sourceLineNo">1952</span> exclude.add(regionState.getServerName());<a name="line.1952"></a>
+<span class="sourceLineNo">1953</span> final List<ServerName> destServers = this.serverManager.createDestinationServersList(exclude);<a name="line.1953"></a>
+<span class="sourceLineNo">1954</span> dest = balancer.randomAssignment(hri, destServers);<a name="line.1954"></a>
+<span class="sourceLineNo">1955</span> if (dest == null) {<a name="line.1955"></a>
+<span class="sourceLineNo">1956</span> LOG.debug("Unable to determine a plan to assign " + hri);<a name="line.1956"></a>
+<span class="sourceLineNo">1957</span> return;<a name="line.1957"></a>
+<span class="sourceLineNo">1958</span> }<a name="line.1958"></a>
+<span class="sourceLineNo">1959</span> } else {<a name="line.1959"></a>
+<span class="sourceLineNo">1960</span> ServerName candidate = ServerName.valueOf(Bytes.toString(destServerName));<a name="line.1960"></a>
+<span class="sourceLineNo">1961</span> dest = balancer.randomAssignment(hri, Lists.newArrayList(candidate));<a name="line.1961"></a>
+<span class="sourceLineNo">1962</span> if (dest == null) {<a name="line.1962"></a>
+<span class="sourceLineNo">1963</span> LOG.debug("Unable to determine a plan to assign " + hri);<a name="line.1963"></a>
+<span class="sourceLineNo">1964</span> return;<a name="line.1964"></a>
+<span class="sourceLineNo">1965</span> }<a name="line.1965"></a>
+<span class="sourceLineNo">1966</span> // TODO: What is this? I don't get it.<a name="line.1966"></a>
+<span class="sourceLineNo">1967</span> if (dest.equals(serverName) && balancer instanceof BaseLoadBalancer<a name="line.1967"></a>
+<span class="sourceLineNo">1968</span> && !((BaseLoadBalancer)balancer).shouldBeOnMaster(hri)) {<a name="line.1968"></a>
+<span class="sourceLineNo">1969</span> // To avoid unnecessary region moving later by balancer. Don't put user<a name="line.1969"></a>
+<span class="sourceLineNo">1970</span> // regions on master.<a name="line.1970"></a>
+<span class="sourceLineNo">1971</span> LOG.debug("Skipping move of region " + hri.getRegionNameAsString()<a name="line.1971"></a>
+<span class="sourceLineNo">1972</span> + " to avoid unnecessary region moving later by load balancer,"<a name="line.1972"></a>
+<span class="sourceLineNo">1973</span> + " because it should not be on master");<a name="line.1973"></a>
+<span class="sourceLineNo">1974</span> return;<a name="line.1974"></a>
+<span class="sourceLineNo">1975</span> }<a name="line.1975"></a>
+<span class="sourceLineNo">1976</span> }<a name="line.1976"></a>
+<span class="sourceLineNo">1977</span><a name="line.1977"></a>
+<span class="sourceLineNo">1978</span> if (dest.equals(regionState.getServerName())) {<a name="line.1978"></a>
+<span class="sourceLineNo">1979</span> LOG.debug("Skipping move of region " + hri.getRegionNameAsString()<a name="line.1979"></a>
+<span class="sourceLineNo">1980</span> + " because region already assigned to the same server " + dest + ".");<a name="line.1980"></a>
+<span class="sourceLineNo">1981</span> return;<a name="line.1981"></a>
+<span class="sourceLineNo">1982</span> }<a name="line.1982"></a>
+<span class="sourceLineNo">1983</span><a name="line.1983"></a>
+<span class="sourceLineNo">1984</span> // Now we can do the move<a name="line.1984"></a>
+<span class="sourceLineNo">1985</span> RegionPlan rp = new RegionPlan(hri, regionState.getServerName(), dest);<a name="line.1985"></a>
+<span class="sourceLineNo">1986</span> assert rp.getDestination() != null: rp.toString() + " " + dest;<a name="line.1986"></a>
+<span class="sourceLineNo">1987</span><a name="line.1987"></a>
+<span class="sourceLineNo">1988</span> try {<a name="line.1988"></a>
+<span class="sourceLineNo">1989</span> checkInitialized();<a name="line.1989"></a>
+<span class="sourceLineNo">1990</span> if (this.cpHost != null) {<a name="line.1990"></a>
+<span class="sourceLineNo">1991</span> this.cpHost.preMove(hri, rp.getSource(), rp.getDestination());<a name="line.1991"></a>
+<span class="sourceLineNo">1992</span> }<a name="line.1992"></a>
+<span class="sourceLineNo">1993</span> // Warmup the region on the destination before initiating the move. this call<a name="line.1993"></a>
+<span class="sourceLineNo">1994</span> // is synchronous and takes some time. doing it before the source region gets<a name="line.1994"></a>
+<span class="sourceLineNo">1995</span> // closed<a name="line.1995"></a>
+<span class="sourceLineNo">1996</span> serverManager.sendRegionWarmup(rp.getDestination(), hri);<a name="line.1996"></a>
+<span class="sourceLineNo">1997</span><a name="line.1997"></a>
+<span class="sourceLineNo">1998</span> LOG.info(getClientIdAuditPrefix() + " move " + rp + ", running balancer");<a name="line.1998"></a>
+<span class="sourceLineNo">1999</span> Future<byte []> future = this.assignmentManager.moveAsync(rp);<a name="line.1999"></a>
+<span class="sourceLineNo">2000</span> try {<a name="line.2000"></a>
+<span class="sourceLineNo">2001</span> // Is this going to work? Will we throw exception on error?<a name="line.2001"></a>
+<span class="sourceLineNo">2002</span> // TODO: CompletableFuture rather than this stunted Future.<a name="line.2002"></a>
+<span class="sourceLineNo">2003</span> future.get();<a name="line.2003"></a>
+<span class="sourceLineNo">2004</span> } catch (InterruptedException | ExecutionException e) {<a name="line.2004"></a>
+<span class="sourceLineNo">2005</span> throw new HBaseIOException(e);<a name="line.2005"></a>
+<span class="sourceLineNo">2006</span> }<a name="line.2006"></a>
+<span class="sourceLineNo">2007</span> if (this.cpHost != null) {<a name="line.2007"></a>
+<span class="sourceLineNo">2008</span> this.cpHost.postMove(hri, rp.getSource(), rp.getDestination());<a name="line.2008"></a>
+<span class="sourceLineNo">2009</span> }<a name="line.2009"></a>
+<span class="sourceLineNo">2010</span> } catch (IOException ioe) {<a name="line.2010"></a>
+<span class="sourceLineNo">2011</span> if (ioe instanceof HBaseIOException) {<a name="line.2011"></a>
+<span class="sourceLineNo">2012</span> throw (HBaseIOException)ioe;<a name="line.2012"></a>
+<span class="sourceLineNo">2013</span> }<a name="line.2013"></a>
+<span class="sourceLineNo">2014</span> throw new HBaseIOException(ioe);<a name="line.2014"></a>
+<span class="sourceLineNo">2015</span> }<a name="line.2015"></a>
+<span class="sourceLineNo">2016</span> }<a name="line.2016"></a>
+<span class="sourceLineNo">2017</span><a name="line.2017"></a>
+<span class="sourceLineNo">2018</span> @Override<a name="line.2018"></a>
+<span class="sourceLineNo">2019</span> public long createTable(<a name="line.2019"></a>
+<span class="sourceLineNo">2020</span> final TableDescriptor tableDescriptor,<a name="line.2020"></a>
+<span class="sourceLineNo">2021</span> final byte [][] splitKeys,<a name="line.2021"></a>
+<span class="sourceLineNo">2022</span> final long nonceGroup,<a name="line.2022"></a>
+<span class="sourceLineNo">2023</span> final long nonce) throws IOException {<a name="line.2023"></a>
+<span class="sourceLineNo">2024</span> checkInitialized();<a name="line.2024"></a>
+<span class="sourceLineNo">2025</span><a name="line.2025"></a>
+<span class="sourceLineNo">2026</span> String namespace = tableDescriptor.getTableName().getNamespaceAsString();<a name="line.2026"></a>
+<span class="sourceLineNo">2027</span> this.clusterSchemaService.getNamespace(namespace);<a name="line.2027"></a>
+<span class="sourceLineNo">2028</span><a name="line.2028"></a>
+<span class="sourceLineNo">2029</span> RegionInfo[] newRegions = ModifyRegionUtils.createRegionInfos(tableDescriptor, splitKeys);<a name="line.2029"></a>
+<span class="sourceLineNo">2030</span> sanityCheckTableDescriptor(tableDescriptor);<a name="line.2030"></a>
+<span class="sourceLineNo">2031</span><a name="line.2031"></a>
+<span class="sourceLineNo">2032</span> return MasterProcedureUtil.submitProcedure(<a name="line.2032"></a>
+<span class="sourceLineNo">2033</span> new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {<a name="line.2033"></a>
+<span class="sourceLineNo">2034</span> @Override<a name="line.2034"></a>
+<span class="sourceLineNo">2035</span> protected void run() throws IOException {<a name="line.2035"></a>
+<span class="sourceLineNo">2036</span> getMaster().getMasterCoprocessorHost().preCreateTable(tableDescriptor, newRegions);<a name="line.2036"></a>
<span class="sourceLineNo">2037</span><a name="line.2037"></a>
-<span class="sourceLineNo">2038</span> // TODO: We can handle/merge duplicate requests, and differentiate the case of<a name="line.2038"></a>
-<span class="sourceLineNo">2039</span> // TableExistsException by saying if the schema is the same or not.<a name="line.2039"></a>
-<span class="sourceLineNo">2040</span> //<a name="line.2040"></a>
-<span class="sourceLineNo">2041</span> // We need to wait for the procedure to potentially fail due to "prepare" sanity<a name="line.2041"></a>
-<span class="sourceLineNo">2042</span> // checks. This will block only the beginning of the procedure. See HBASE-19953.<a name="line.2042"></a>
-<span class="sourceLineNo">2043</span> ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch();<a name="line.2043"></a>
-<span class="sourceLineNo">2044</span> submitProcedure(new CreateTableProcedure(<a name="line.2044"></a>
-<span class="sourceLineNo">2045</span> procedureExecutor.getEnvironment(), tableDescriptor, newRegions, latch));<a name="line.2045"></a>
-<span class="sourceLineNo">2046</span> latch.await();<a name="line.2046"></a>
-<span class="sourceLineNo">2047</span><a name="line.2047"></a>
-<span class="sourceLineNo">2048</span> getMaster().getMasterCoprocessorHost().postCreateTable(tableDescriptor, newRegions);<a name="line.2048"></a>
-<span class="sourceLineNo">2049</span> }<a name="line.2049"></a>
-<span class="sourceLineNo">2050</span><a name="line.2050"></a>
-<span class="sourceLineNo">2051</span> @Override<a name="line.2051"></a>
-<span class="sourceLineNo">2052</span> protected String getDescription() {<a name="line.2052"></a>
-<span class="sourceLineNo">2053</span> return "CreateTableProcedure";<a name="line.2053"></a>
-<span class="sourceLineNo">2054</span> }<a name="line.2054"></a>
-<span class="sourceLineNo">2055</span> });<a name="line.2055"></a>
-<span class="sourceLineNo">2056</span> }<a name="line.2056"></a>
-<span class="sourceLineNo">2057</span><a name="line.2057"></a>
-<span class="sourceLineNo">2058</span> @Override<a name="line.2058"></a>
-<span class="sourceLineNo">2059</span> public long createSystemTable(final TableDescriptor tableDescriptor) throws IOException {<a name="line.2059"></a>
-<span class="sourceLineNo">2060</span> if (isStopped()) {<a name="line.2060"></a>
-<span class="sourceLineNo">2061</span> throw new MasterNotRunningException();<a name="line.2061"></a>
-<span class="sourceLineNo">2062</span> }<a name="line.2062"></a>
-<span class="sourceLineNo">2063</span><a name="line.2063"></a>
-<span class="sourceLineNo">2064</span> TableName tableName = tableDescriptor.getTableName();<a name="line.2064"></a>
-<span class="sourceLineNo">2065</span> if (!(tableName.isSystemTable())) {<a name="line.2065"></a>
-<span class="sourceLineNo">2066</span> throw new IllegalArgumentException(<a name="line.2066"></a>
-<span class="sourceLineNo">2067</span> "Only system table creation can use this createSystemTable API");<a name="line.2067"></a>
-<span class="sourceLineNo">2068</span> }<a name="line.2068"></a>
-<span class="sourceLineNo">2069</span><a name="line.2069"></a>
-<span class="sourceLineNo">2070</span> RegionInfo[] newRegions = ModifyRegionUtils.createRegionInfos(tableDescriptor, null);<a name="line.2070"></a>
+<span class="sourceLineNo">2038</span> LOG.info(getClientIdAuditPrefix() + " create " + tableDescriptor);<a name="line.2038"></a>
+<span class="sourceLineNo">2039</span><a name="line.2039"></a>
+<span class="sourceLineNo">2040</span> // TODO: We can handle/merge duplicate requests, and differentiate the case of<a name="line.2040"></a>
+<span class="sourceLineNo">2041</span> // TableExistsException by saying if the schema is the same or not.<a name="line.2041"></a>
+<span class="sourceLineNo">2042</span> //<a name="line.2042"></a>
+<span class="sourceLineNo">2043</span> // We need to wait for the procedure to potentially fail due to "prepare" sanity<a name="line.2043"></a>
+<span class="sourceLineNo">2044</span> // checks. This will block only the beginning of the procedure. See HBASE-19953.<a name="line.2044"></a>
+<span class="sourceLineNo">2045</span> ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch();<a name="line.2045"></a>
+<span class="sourceLineNo">2046</span> submitProcedure(new CreateTableProcedure(<a name="line.2046"></a>
+<span class="sourceLineNo">2047</span> procedureExecutor.getEnvironment(), tableDescriptor, newRegions, latch));<a name="line.2047"></a>
+<span class="sourceLineNo">2048</span> latch.await();<a name="line.2048"></a>
+<span class="sourceLineNo">2049</span><a name="line.2049"></a>
+<span class="sourceLineNo">2050</span> getMaster().getMasterCoprocessorHost().postCreateTable(tableDescriptor, newRegions);<a name="line.2050"></a>
+<span class="sourceLineNo">2051</span> }<a name="line.2051"></a>
+<span class="sourceLineNo">2052</span><a name="line.2052"></a>
+<span class="sourceLineNo">2053</span> @Override<a name="line.2053"></a>
+<span class="sourceLineNo">2054</span> protected String getDescription() {<a name="line.2054"></a>
+<span class="sourceLineNo">2055</span> return "CreateTableProcedure";<a name="line.2055"></a>
+<span class="sourceLineNo">2056</span> }<a name="line.2056"></a>
+<span class="sourceLineNo">2057</span> });<a name="line.2057"></a>
+<span class="sourceLineNo">2058</span> }<a name="line.2058"></a>
+<span class="sourceLineNo">2059</span><a name="line.2059"></a>
+<span class="sourceLineNo">2060</span> @Override<a name="line.2060"></a>
+<span class="sourceLineNo">2061</span> public long createSystemTable(final TableDescriptor tableDescriptor) throws IOException {<a name="line.2061"></a>
+<span class="sourceLineNo">2062</span> if (isStopped()) {<a name="line.2062"></a>
+<span class="sourceLineNo">2063</span> throw new MasterNotRunningException();<a name="line.2063"></a>
+<span class="sourceLineNo">2064</span> }<a name="line.2064"></a>
+<span class="sourceLineNo">2065</span><a name="line.2065"></a>
+<span class="sourceLineNo">2066</span> TableName tableName = tableDescriptor.getTableName();<a name="line.2066"></a>
+<span class="sourceLineNo">2067</span> if (!(tableName.isSystemTable())) {<a name="line.2067"></a>
+<span class="sourceLineNo">2068</span> throw new IllegalArgumentException(<a name="line.2068"></a>
+<span class="sourceLineNo">2069</span> "Only system table creation can use this createSystemTable API");<a name="line.2069"></a>
+<span class="sourceLineNo">2070</span> }<a name="line.2070"></a>
<span class="sourceLineNo">2071</span><a name="line.2071"></a>
-<span class="sourceLineNo">2072</span> LOG.info(getClientIdAuditPrefix() + " create " + tableDescriptor);<a name="line.2072"></a>
+<span class="sourceLineNo">2072</span> RegionInfo[] newRegions = ModifyRegionUtils.createRegionInfos(tableDescriptor, null);<a name="line.2072"></a>
<span class="sourceLineNo">2073</span><a name="line.2073"></a>
-<span class="sourceLineNo">2074</span> // This special create table is called locally to master. Therefore, no RPC means no need<a name="line.2074"></a>
-<span class="sourceLineNo">2075</span> // to use nonce to detect duplicated RPC call.<a name="line.2075"></a>
-<span class="sourceLineNo">2076</span> long procId = this.procedureExecutor.submitProcedure(<a name="line.2076"></a>
-<span class="sourceLineNo">2077</span> new CreateTableProcedure(procedureExecutor.getEnvironment(), tableDescriptor, newRegions));<a name="line.2077"></a>
-<span class="sourceLineNo">2078</span><a name="line.2078"></a>
-<span class="sourceLineNo">2079</span> return procId;<a name="line.2079"></a>
-<span class="sourceLineNo">2080</span> }<a name="line.2080"></a>
-<span class="sourceLineNo">2081</span><a name="line.2081"></a>
-<span class="sourceLineNo">2082</span> /**<a name="line.2082"></a>
-<span class="sourceLineNo">2083</span> * Checks whether the table conforms to some sane limits, and configured<a name="line.2083"></a>
-<span class="sourceLineNo">2084</span> * values (compression, etc) work. Throws an exception if something is wrong.<a name="line.2084"></a>
-<span class="sourceLineNo">2085</span> * @throws IOException<a name="line.2085"></a>
-<span class="sourceLineNo">2086</span> */<a name="line.2086"></a>
-<span class="sourceLineNo">2087</span> private void sanityCheckTableDescriptor(final TableDescriptor htd) throws IOException {<a name="line.2087"></a>
-<span class="sourceLineNo">2088</span> final String CONF_KEY = "hbase.table.sanity.checks";<a name="line.2088"></a>
-<span class="sourceLineNo">2089</span> boolean logWarn = false;<a name="line.2089"></a>
-<span class="sourceLineNo">2090</span> if (!conf.getBoolean(CONF_KEY, true)) {<a name="line.2090"></a>
-<span class="sourceLineNo">2091</span> logWarn = true;<a name="line.2091"></a>
-<span class="sourceLineNo">2092</span> }<a name="line.2092"></a>
-<span class="sourceLineNo">2093</span> String tableVal = htd.getValue(CONF_KEY);<a name="line.2093"></a>
-<span class="sourceLineNo">2094</span> if (tableVal != null && !Boolean.valueOf(tableVal)) {<a name="line.2094"></a>
-<span class="sourceLineNo">2095</span> logWarn = true;<a name="line.2095"></a>
-<span class="sourceLineNo">2096</span> }<a name="line.2096"></a>
-<span class="sourceLineNo">2097</span><a name="line.2097"></a>
-<span class="sourceLineNo">2098</span> // check max file size<a name="line.2098"></a>
-<span class="sourceLineNo">2099</span> long maxFileSizeLowerLimit = 2 * 1024 * 1024L; // 2M is the default lower limit<a name="line.2099"></a>
-<span class="sourceLineNo">2100</span> long maxFileSize = htd.getMaxFileSize();<a name="line.2100"></a>
-<span class="sourceLineNo">2101</span> if (maxFileSize < 0) {<a name="line.2101"></a>
-<span class="sourceLineNo">2102</span> maxFileSize = conf.getLong(HConstants.HREGION_MAX_FILESIZE, maxFileSizeLowerLimit);<a name="line.2102"></a>
-<span class="sourceLineNo">2103</span> }<a name="line.2103"></a>
-<span class="sourceLineNo">2104</span> if (maxFileSize < conf.getLong("hbase.hregion.max.filesize.limit", maxFileSizeLowerLimit)) {<a name="line.2104"></a>
-<span class="sourceLineNo">2105</span> String message = "MAX_FILESIZE for table descriptor or "<a name="line.2105"></a>
-<span class="sourceLineNo">2106</span> + "\"hbase.hregion.max.filesize\" (" + maxFileSize<a name="line.2106"></a>
-<span class="sourceLineNo">2107</span> + ") is too small, which might cause over splitting into unmanageable "<a name="line.2107"></a>
-<span class="sourceLineNo">2108</span> + "number of regions.";<a name="line.2108"></a>
-<span class="sourceLineNo">2109</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2109"></a>
-<span class="sourceLineNo">2110</span> }<a name="line.2110"></a>
-<span class="sourceLineNo">2111</span><a name="line.2111"></a>
-<span class="sourceLineNo">2112</span> // check flush size<a name="line.2112"></a>
-<span class="sourceLineNo">2113</span> long flushSizeLowerLimit = 1024 * 1024L; // 1M is the default lower limit<a name="line.2113"></a>
-<span class="sourceLineNo">2114</span> long flushSize = htd.getMemStoreFlushSize();<a name="line.2114"></a>
-<span class="sourceLineNo">2115</span> if (flushSize < 0) {<a name="line.2115"></a>
-<span class="sourceLineNo">2116</span> flushSize = conf.getLong(HConstants.HREGION_MEMSTORE_FLUSH_SIZE, flushSizeLowerLimit);<a name="line.2116"></a>
-<span class="sourceLineNo">2117</span> }<a name="line.2117"></a>
-<span class="sourceLineNo">2118</span> if (flushSize < conf.getLong("hbase.hregion.memstore.flush.size.limit", flushSizeLowerLimit)) {<a name="line.2118"></a>
-<span class="sourceLineNo">2119</span> String message = "MEMSTORE_FLUSHSIZE for table descriptor or "<a name="line.2119"></a>
-<span class="sourceLineNo">2120</span> + "\"hbase.hregion.memstore.flush.size\" ("+flushSize+") is too small, which might cause"<a name="line.2120"></a>
-<span class="sourceLineNo">2121</span> + " very frequent flushing.";<a name="line.2121"></a>
-<span class="sourceLineNo">2122</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2122"></a>
-<span class="sourceLineNo">2123</span> }<a name="line.2123"></a>
-<span class="sourceLineNo">2124</span><a name="line.2124"></a>
-<span class="sourceLineNo">2125</span> // check that coprocessors and other specified plugin classes can be loaded<a name="line.2125"></a>
-<span class="sourceLineNo">2126</span> try {<a name="line.2126"></a>
-<span class="sourceLineNo">2127</span> checkClassLoading(conf, htd);<a name="line.2127"></a>
-<span class="sourceLineNo">2128</span> } catch (Exception ex) {<a name="line.2128"></a>
-<span class="sourceLineNo">2129</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, ex.getMessage(), null);<a name="line.2129"></a>
-<span class="sourceLineNo">2130</span> }<a name="line.2130"></a>
-<span class="sourceLineNo">2131</span><a name="line.2131"></a>
-<span class="sourceLineNo">2132</span> // check compression can be loaded<a name="line.2132"></a>
-<span class="sourceLineNo">2133</span> try {<a name="line.2133"></a>
-<span class="sourceLineNo">2134</span> checkCompression(htd);<a name="line.2134"></a>
-<span class="sourceLineNo">2135</span> } catch (IOException e) {<a name="line.2135"></a>
-<span class="sourceLineNo">2136</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, e.getMessage(), e);<a name="line.2136"></a>
-<span class="sourceLineNo">2137</span> }<a name="line.2137"></a>
-<span class="sourceLineNo">2138</span><a name="line.2138"></a>
-<span class="sourceLineNo">2139</span> // check encryption can be loaded<a name="line.2139"></a>
-<span class="sourceLineNo">2140</span> try {<a name="line.2140"></a>
-<span class="sourceLineNo">2141</span> checkEncryption(conf, htd);<a name="line.2141"></a>
-<span class="sourceLineNo">2142</span> } catch (IOException e) {<a name="line.2142"></a>
-<span class="sourceLineNo">2143</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, e.getMessage(), e);<a name="line.2143"></a>
-<span class="sourceLineNo">2144</span> }<a name="line.2144"></a>
-<span class="sourceLineNo">2145</span> // Verify compaction policy<a name="line.2145"></a>
-<span class="sourceLineNo">2146</span> try{<a name="line.2146"></a>
-<span class="sourceLineNo">2147</span> checkCompactionPolicy(conf, htd);<a name="line.2147"></a>
-<span class="sourceLineNo">2148</span> } catch(IOException e){<a name="line.2148"></a>
-<span class="sourceLineNo">2149</span> warnOrThrowExceptionForFailure(false, CONF_KEY, e.getMessage(), e);<a name="line.2149"></a>
-<span class="sourceLineNo">2150</span> }<a name="line.2150"></a>
-<span class="sourceLineNo">2151</span> // check that we have at least 1 CF<a name="line.2151"></a>
-<span class="sourceLineNo">2152</span> if (htd.getColumnFamilyCount() == 0) {<a name="line.2152"></a>
-<span class="sourceLineNo">2153</span> String message = "Table should have at least one column family.";<a name="line.2153"></a>
-<span class="sourceLineNo">2154</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2154"></a>
-<span class="sourceLineNo">2155</span> }<a name="line.2155"></a>
-<span class="sourceLineNo">2156</span><a name="line.2156"></a>
-<span class="sourceLineNo">2157</span> for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {<a name="line.2157"></a>
-<span class="sourceLineNo">2158</span> if (hcd.getTimeToLive() <= 0) {<a name="line.2158"></a>
-<span class="sourceLineNo">2159</span> String message = "TTL for column family " + hcd.getNameAsString() + " must be positive.";<a name="line.2159"></a>
-<span class="sourceLineNo">2160</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2160"></a>
-<span class="sourceLineNo">2161</span> }<a name="line.2161"></a>
-<span class="sourceLineNo">2162</span><a name="line.2162"></a>
-<span class="sourceLineNo">2163</span> // check blockSize<a name="line.2163"></a>
-<span class="sourceLineNo">2164</span> if (hcd.getBlocksize() < 1024 || hcd.getBlocksize() > 16 * 1024 * 1024) {<a name="line.2164"></a>
-<span class="sourceLineNo">2165</span> String message = "Block size for column family " + hcd.getNameAsString()<a name="line.2165"></a>
-<span class="sourceLineNo">2166</span> + " must be between 1K and 16MB.";<a name="line.2166"></a>
-<span class="sourceLineNo">2167</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2167"></a>
-<span class="sourceLineNo">2168</span> }<a name="line.2168"></a>
-<span class="sourceLineNo">2169</span><a name="line.2169"></a>
-<span class="sourceLineNo">2170</span> // check versions<a name="line.2170"></a>
-<span class="sourceLineNo">2171</span> if (hcd.getMinVersions() < 0) {<a name="line.2171"></a>
-<span class="sourceLineNo">2172</span> String message = "Min versions for column family " + hcd.getNameAsString()<a name="line.2172"></a>
-<span class="sourceLineNo">2173</span> + " must be positive.";<a name="line.2173"></a>
-<span class="sourceLineNo">2174</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2174"></a>
-<span class="sourceLineNo">2175</span> }<a name="line.2175"></a>
-<span class="sourceLineNo">2176</span> // max versions already being checked<a name="line.2176"></a>
-<span class="sourceLineNo">2177</span><a name="line.2177"></a>
-<span class="sourceLineNo">2178</span> // HBASE-13776 Setting illegal versions for ColumnFamilyDescriptor<a name="line.2178"></a>
-<span class="sourceLineNo">2179</span> // does not throw IllegalArgumentException<a name="line.2179"></a>
-<span class="sourceLineNo">2180</span> // check minVersions <= maxVerions<a name="line.2180"></a>
-<span class="sourceLineNo">2181</span> if (hcd.getMinVersions() > hcd.getMaxVersions()) {<a name="line.2181"></a>
-<span class="sourceLineNo">2182</span> String message = "Min versions for column family " + hcd.getNameAsString()<a name="line.2182"></a>
-<span class="sourceLineNo">2183</span> + " must be less than the Max versions.";<a name="line.2183"></a>
-<span class="sourceLineNo">2184</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2184"></a>
-<span class="sourceLineNo">2185</span> }<a name="line.2185"></a>
-<span class="sourceLineNo">2186</span><a name="line.2186"></a>
-<span class="sourceLineNo">2187</span> // check replication scope<a name="line.2187"></a>
-<span class="sourceLineNo">2188</span> checkReplicationScope(hcd);<a name="line.2188"></a>
-<span class="sourceLineNo">2189</span> // check bloom filter type<a name="line.2189"></a>
-<span class="sourceLineNo">2190</span> checkBloomFilterType(hcd);<a name="line.2190"></a>
-<span class="sourceLineNo">2191</span><a name="line.2191"></a>
-<span class="sourceLineNo">2192</span> // check data replication factor, it can be 0(default value) when user has not explicitly<a name="line.2192"></a>
-<span class="sourceLineNo">2193</span> // set the value, in this case we use default replication factor set in the file system.<a name="line.2193"></a>
-<span class="sourceLineNo">2194</span> if (hcd.getDFSReplication() < 0) {<a name="line.2194"></a>
-<span class="sourceLineNo">2195</span> String message = "HFile Replication for column family " + hcd.getNameAsString()<a name="line.2195"></a>
-<span class="sourceLineNo">2196</span> + " must be greater than zero.";<a name="line.2196"></a>
-<span class="sourceLineNo">2197</span> warnOrThrowExceptionForFailure(logWarn, CONF_KEY, message, null);<a name="line.2197"></a>
-<span class="sourceLineNo">2198</span> }<a name="line.2198"></a>
-<span class="sourceLineNo">2199</span><a name="line.2199"></a>
-<span class="sourceLineNo">2200</span> // TODO: should we check coprocessors and encryption ?<a name="line.2200"></a>
-<span class="sourceLineNo">2201</span> }<a name="line.2201"></a>
-<span class="sourceLineNo">2202</span> }<a name="line.2202"></a>
-<span class="sourceLineNo">2203</span><a name="line.2203"></a>
-<span class="sourceLineNo">2204</span> private void checkReplicationScope(ColumnFamilyDescriptor hcd) throws IOException{<a name="line.2204"></a>
-<span class="sourceLineNo">2205</span> // check replication scope<a name="line.2205"></a>
-<span class="sourceLineNo">2206</span> WALProtos.ScopeType scop = WALProtos.ScopeType.valueOf(hcd.getScope());<a name="line.2206"></a>
-<span class="sourceLineNo">2207</span> if (scop == null) {<a name="line.2207"></a>
-<span class="sourceLineNo">2208</span> String message = "Replication scope for column family "<a name="line.2208"></a>
-<span class="sourceLineNo">2209</span> + hcd.getNameAsString() + " is " + hcd.getScope() + " which is invalid.";<a name="line.2209"></a>
-<span class="sourceLineNo">2210</span><a name="line.2210"></a>
-<span class="sourceLineNo">2211</span> LOG.error(message);<a name="line.2211"></a>
-<span class="sourceLineNo">2212</span> throw new DoNotRetryIOException(message);<a name="line.2212"></a>
-<span class="sourceLineNo">2213</span> }<a name="line.2213"></a>
-<span class="sourceLineNo">2214</span> }<a name="line.2214"></a>
-<span class="sourceLineNo">2215</span><a name="line.2215"></a>
-<span class="sourceLineNo">2216</span> private void checkCompactionPolicy(Configuration conf, TableDescriptor htd)<a name="line.2216"></a>
-<span class="sourceLineNo">2217</span> throws IOException {<a name="line.2217"></a>
-<span class="sourceLineNo">2218</span> // FIFO compaction has some requirements<a name="line.2218"></a>
-<span class="sourceLineNo">2219</span> // Actually FCP ignores periodic major compactions<a name="line.2219"></a>
-<span class="sourceLineNo">2220</span> String className = htd.getValue(DefaultStoreEngine.DEFAULT_COMPACTION_POLICY_CLASS_KEY);<a name="line.2220"></a>
-<span class="sourceLineNo">2221</span> if (className == null) {<a name="line.2221"></a>
-<span class="sourceLineNo">2222</span> className =<a name="line.2222"></a>
-<span class="sourceLineNo">2223</span> conf.get(DefaultStoreEngine.DEFAULT_COMPACTION_POLICY_CLASS_KEY,<a name="line.2223"></a>
-<span class="sourceLineNo">2224</span> ExploringCompactionPolicy.class.getName());<a name="line.2224"></a>
-<span class="sourceLineNo">2225</span> }<a name="line.2225"></a>
-<span class="sourceLineNo">2226</span><a name="line.2226"></a>
-<span class="sourceLineNo">2227</span> int blockingFileCount = HStore.DEFAULT_BLOCKING_STOREFILE_COUNT;<a name="line.2227"></a>
-<span class="sourceLineNo">2228</span> String sv = htd.getValue(HStore.BLOCKING_STOREFILES_KEY);<a name="line.2228"></a>
-<span class="sourceLineNo">2229</span> if (sv != null) {<a name="line.2229"></a>
-<span class="sourceLineNo">2230</span> blockingFileCount = Integer.parseInt(sv);<a name="line.2230"></a>
-<span class="sourceLineNo">2231</span> } else {<a name="line.2231"></a>
-<span class="sourceLineNo">2232</span> blockingFileCount = conf.getInt(HStore.BLOCKING_STOREFILES_KEY, blockingFileCount);<a name="line.2232"></a>
-<span class="sourceLineNo">2233</span> }<a name="line.2233"></a>
-<span class="sourceLineNo">2234</span><a name="line.2234"></a>
-<span class="sourceLineNo">2235</span> for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {<a name="line.2235"></a>
-<span class="sourceLineNo">2236</span> String compactionPolicy =<a name="line.2236"></a>
-<span class="sourceLineNo">2237</span> hcd.getConfigurationValue(DefaultStoreEngine.DEFAULT_COMPACTION_POLICY_CLASS_KEY);<a name="line.2237"></a>
-<span class="sourceLineNo">2238</span> if (compactionPolicy == null) {<a name="line.2238"></a>
-<span class="sourceLineNo">2239</span> compactionPolicy = className;<a name="line.2239"></a>
-<span class="sourceLineNo">2240</span> }<a name="line.2240"></a>
-<span class="sourceLineNo">2241</span> if (!compactionPolicy.equals(FIFOCompactionPolicy.class.getName())) {<a name="line.2241"></a>
-<span class="sourceLineNo">2242</span> continue;<a name="line.2242"></a>
-<span class="sourceLineNo">2243</span> }<a name="line.2243"></a>
-<span class="sourceLineNo">2244</span> // FIFOCompaction<a name="line.2244"></a>
-<span class="sourceLineNo">2245</span> String message = null;<a name="line.2245"></a>
-<span class="sourceLineNo">2246</span><a name="line.2246"></a>
-<span class="sourceLineNo">2247</span> // 1. Check TTL<a name="line.2247"></a>
-<span class="sourceLineNo">2248</span> if (hcd.getTimeToLive() == ColumnFamilyDescriptorBuilder.DEFAULT_TTL) {<a name="line.2248"></a>
-<span class="sourceLineNo">2249</span> message = "Default TTL is not supported for FIFO compaction";<a name="line.2249"></a>
-<span class="sourceLineNo">2250</span> throw new IOException(message);<a name="line.2250"></a>
-<span class="sourceLineNo">2251</span> }<a name="line.2251"></a>
-<span class="sourceLineNo">2252</span><a name="line.2252"></a>
-<span class="sourceLineNo">2253</span> // 2. Check min versions<a name="line.2253"></a>
-<span class="sourceLineNo">2254</span> if (hcd.getMinVersions() > 0) {<a name="line.2254"></a>
-<span class="sourceLineNo">2255</span> message = "MIN_VERSION > 0 is not supported for FIFO compaction";<a name="line.2255"></a>
-<span class="sourceLineNo">2256</span> throw new IOException(message);<a name="line.2256"></a>
-<span class="sourceLineNo">2257</span> }<a name="line.2257"></a>
-<span class="sourceLineNo">2258</span><a name="line.2258"></a>
-<span class="sourceLineNo">2259</span> // 3. blocking file count<a name="line.2259"></a>
-<span class="sourceLineNo">2260</span> sv = hcd.getConfigurationValue(HStore.BLOCKING_STOREFILES_KEY);<a name="line.2260"></a>
-<span class="sourceLineNo">2261</span> if (sv != null) {<a name="line.2261"></a>
-<span class="sourceLineNo">2262</span> blockingFileCount = Integer.parseInt(sv);<a name="line.2262"></a>
-<span class="sourceLineNo">2263</span> }<a name="line.2263"></a>
-<span class="sourceLineNo">2264</span> if (blockingFileCount < 1000) {<a name="line.2264"></a>
-<span class="sourceLineNo">2265</span> message =<a name="line.2265"></a>
-<span class="sourceLineNo">2266</span> "Blocking file count '" + HStore.BLOCKING_STOREFILES_KEY + "' " + blockingFileCount<a name="line.2266"></a>
-<span class="sourceLineNo">2267</span> + " is below recommended minimum of 1000 for column family "+ hcd.getNameAsString();<a name="line.2267"></a>
-<span class="sourceLineNo">2268</span> throw new IOException(message);<a name="line.2268"></a>
-<span class="sourceLineNo">2269</span> }<a name="line.2269"></a>
-<span class="sourceLineNo">2270</span> }<a name="line.2270"></a>
-<span class="sourceLineNo">2271</span> }<a name="line.2271"></a>
-<span class="sourceLineNo">2272</span><a name="line.2272"></a>
-<span class="sourceLineNo">2273</span> private static void checkBloomFilterType(ColumnFamilyDescriptor cfd)<a name="line.2273"></a>
-<span class="sourceLineNo">2274</span> throws IOException {<a name="line.2274"></a>
-<span class="sourceLineNo">2275</span> Configuration conf = new CompoundConfiguration().addStringMap(cfd.getConfiguration());<a name="line.2275"></a>
-<span class="sourceLineNo">2276</span> try {<a name="line.2276"></a>
-<span class="sourceLineNo">2277</span> BloomFilterUtil.getBloomFilterParam(cfd.getBloomFilterType(), conf);<a name="line.2277"></a>
-<span class="sourceLineNo">2278</span> } catch (IllegalArgumentException e) {<a name="line.2278"></a>
-<span class="sourceLineNo">2279</span> throw new DoNotRetryIOException("Failed to get bloom filter param", e);<a name="line.2279"></a>
-<span class="sourceLineNo">2280</span> }<a name="line.2280"></a>
-<span class="sourceLineNo">2281</span> }<a name="line.2281"></a>
-<span class="sourceLineNo">2282</span><a name="line.2282"></a>
-<span class="sourceLineNo">2283</span> // HBASE-13350 - Helper method to log warning on sanity check failures if checks disabled.<a name="line.2283"></a>
-<span class="sourceLineNo">2284</span> private static void warnOrThrowExceptionForFailure(boolean logWarn, String confKey,<a name="line.2284"></a>
-<span class="sourceLineNo">2285</span> String message, Exception cause) throws IOException {<a name="line.2285"></a>
-<span class="sourceLineNo">2286</span> if (!logWarn) {<a name="line.2286"></a>
-<span class="sourceLineNo">2287</span> throw new DoNotRetryIOException(message + " Set " + confKey +<a name="line.2287"></a>
-<span class="sourceLineNo">2288</span> " to false at conf or table descriptor if you want to bypass sanity checks", cause);<a name="line.2288"></a>
-<span class="sourceLineNo">2289</span> }<a name="line.2289"></a>
-<span class="sourceLineNo">2290</span> LOG.warn(message);<a name="line.2290"></a>
-<span class="sourceLineNo">2291</span> }<a name="line.2291"></a>
-<span class="sourceLineNo">2292</span><a name="line.2292"></a>
-<span class="sourceLineNo">2293</span> private void startActiveMasterManager(int infoPort) throws KeeperException {<a name="line.2293"></a>
-<span class="sourceLineNo">2294</span> String backupZNode = ZNodePaths.joinZNode(<a name="line.2294"></a>
-<span class="sourceLineNo">2295</span> zooKeeper.getZNodePaths().backupMasterAddressesZNode, serverName.toString());<a name="line.2295"></a>
-<span class="sourceLineNo">2296</span> /*<a name="line.2296"></a>
-<span class="sourceLineNo">2297</span> * Add a ZNode for ourselves in the backup master directory since we<a name="line.2297"></a>
-<span class="sourceLineNo">2298</span> * may not become the active master. If so, we want the actual active<a name="line.2298"></a>
-<span class="sourceLineNo">2299</span> * master to know we are backup masters, so that it won't assign<a name="line.2299"></a>
-<span class="sourceLineNo">2300</span> * regions to us if so configured.<a name="line.2300"></a>
-<span class="sourceLineNo">2301</span> *<a name="line.2301"></a>
-<span class="sourceLineNo">2302</span> * If we become the active master later, ActiveMasterManager will delete<a name="line.2302"></a>
-<span class="sourceLineNo">2303</span> * this node explicitly. If we crash before then, ZooKeeper will delete<a name="line.2303"></a>
-<span class="sourceLineNo">2304</span> * this node for us since it is ephemeral.<a name="line.2304"></a>
-<span class="sourceLineNo">2305</span> */<a name="line.2305"></a>
-<span class="sourceLineNo">2306</span> LOG.info("Adding backup master ZNode " + backupZNode);<a name="line.2306"></a>
-<span class="sourceLineNo">2307</span> if (!MasterAddressTracker.setMasterAddress(zooKeeper, backupZNode, serverName, infoPort)) {<a name="line.2307"></a>
-<span class="sourceLineNo">2308</span> LOG.warn("Failed create of " + backupZNode + " by " + serverName);<a name="line.2308"></a>
-<span class="sourceLineNo">2309</span> }<a name="line.2309"></a>
-<span class="sourceLineNo">2310</span> this.activeMasterManager.setInfoPort(infoPort);<a name="line.2310"></a>
-<span class="sourceLineNo">2311</span> int timeout = conf.getInt(HConstants.ZK_SESSION_TIMEOUT, HConstants.DEFAULT_ZK_SESSION_TIMEOUT);<a name="line.2311"></a>
-<span class="sourceLineNo">2312</span> // If we're a backup master, stall until a primary to write this address<a name="line.2312"></a>
-<span class="sourceLineNo">2313</span> if (conf.getBoolean(HConstants.MASTER_TYPE_BACKUP, HConstants.DEFAULT_MASTER_TYPE_BACKUP)) {<a name="line.2313"></a>
-<span class="sourceLineNo">2314</span> LOG.debug("HMaster started in backup mode. Stalling until master znode is written.");<a name="line.2314"></a>
-<span class="sourceLineNo">2315</span> // This will only be a minute or so while the cluster starts up,<a name="line.2315"></a>
-<span class="sourceLineNo">2316</span> // so don't worry about setting watches on the parent znode<a name="line.2316"></a>
-<span class="sourceLineNo">2317</span> while (!activeMasterManager.hasActiveMaster()) {<a name="line.2317"></a>
-<span class="sourceLineNo">2318</span> LOG.debug("Waiting for master address and cluster state znode to be written.");<a name="line.2318"></a>
-<span class="sourceLineNo">2319</span> Threads.sleep(timeout);<a name="line.2319"></a>
-<span class="sourceLineNo">2320</span> }<a name="line.2320"></a>
-<span class="sourceLineNo">2321</span> }<a name="line.2321"></a>
-<span class="sourceLineNo">2322</span> MonitoredTask status = TaskMonitor.get().createStatus("Master startup");<a name="line.2322"></a>
-<span class="sourceLineNo">2323</span> status.setDescription("Master startup");<a name="line.2323"></a>
-<span class="sourceLineNo">2324</span> try {<a name="line.2324"></a>
-<span class="sourceLineNo">2325</span> if (activeMasterManager.blockUntilBecomingActiveMaster(timeout, status)) {<a name="line.2325"></a>
-<span class="sourceLineNo">2326</span> finishActiveMasterInitialization(status);<a name="line.2326"></a>
-<span class="sourceLineNo">2327</span> }<a name="line.2327"></a>
-<span class="sourceLineNo">2328</span> } catch (Throwable t) {<a name="line.2328"></a>
-<span class="sourceLineNo">2329</span> status.setStatus("Failed to become active: " + t.getMessage());<a name="line.2329"></a>
-<span class="sourceLineNo">2330</span> LOG.error(HBaseMarkers.FATAL, "Failed to become active master", t);<a name="line.2330"></a>
-<span class="sourceLineNo">2331</span> // HBASE-5680: Likely hadoop23 vs hadoop 20.x/1.x incompatibility<a name="line.2331"></a>
-<span class="sourceLineNo">2332</span> if (t instanceof NoClassDefFoundError && t.getMessage().<a name="line.2332"></a>
-<span class="sourceLineNo">2333</span> contains("org/apache/hadoop/hdfs/protocol/HdfsConstants$SafeModeAction")) {<a name="line.2333"></a>
-<span class="sourceLineNo">2334</span> // improved error message for this special case<a name="line.2334"></a>
-<span class="sourceLineNo">2335</span> abort("HBase is having a problem with its Hadoop jars. You may need to recompile " +<a name="line.2335"></a>
-<span class="sourceLineNo">2336</span> "HBase against Hadoop version " + org.apache.hadoop.util.VersionInfo.getVersion() +<a name="line.2336"></a>
-<span class="sourceLineNo">2337</span> " or change your hadoop jars to start properly", t);<a name="line.2337"></a>
-<span class="sourceLineNo">2338</span> } else {<a name="line.2338"></a>
-<span class="sourceLineNo">2339</span> abort("Unhandled exception. Starting shutdown.", t);<a name="line.2339"></a>
-<span class="sourceLineNo">2340</span> }<a name="line.2340"></a>
-<span class="sourceLineNo">2341</span> } finally {<a name="line.2341"></a>
-<span class="sourceLineNo">2342</span> status.cleanup();<a name="line.2342"></a>
-<span class="sourceLineNo">2343</span> }<a name="line.2343"></a>
-<span class="sourceLineNo">2344</span> }<a name="line.2344"></a>
-<span class="sourceLineNo">2345</span><a name="line.2345"></a>
-<span class="sourceLineNo">2346</span> private void checkCompression(final TableDescriptor htd)<a name="line.2346"></a>
-<span class="sourceLineNo">2347</span> throws IOException {<a name="line.2347"></a>
-<span class="sourceLineNo">2348</span> if (!this.masterCheckCompression) return;<a name="line.2348"></a>
-<span class="sourceLineNo">2349</span> for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {<a name="line.2349"></a>
-<span class="sourceLineNo">2350</span> checkCompression(hcd);<a name="line.2350"></a>
-<span class="sourceLineNo">2351</span> }<a name="line.2351"></a>
-<span class="sourceLineNo">2352</span> }<a name="line.2352"></a>
-<span class="sourceLineNo">2353</span><a name="line.2353"></a>
-<span class="sourceLineNo">2354</span> private void checkCompression(final ColumnFamilyDescriptor hcd)<a name="line.2354"></a>
-<span class="sourceLineNo">2355</span> throws IOException {<a name="line.2355"></a>
-<span class="sourceLineNo">2356</span> if (!this.masterCheckCompression) return;<a name="line.2356"></a>
-<span class="sourceLineNo">2357</span> CompressionTest.testCompression(hcd.getCompressionType());<a name="line.2357"></a>
-<span class="sourceLineNo">2358</span> CompressionTest.testCompression(hcd.getCompactionCompressionType());<a name="line.2358"><
<TRUNCATED>