You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/01/19 13:20:27 UTC
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1159
Fix DynamicFabric locations
- When locations are defined at the YAML top-level, then ensure the
DynamicFabric finds those.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/DynamicFabric-locations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1159
----
commit 58226b70d9f2d271cfa793f7a2a0380d3db8e655
Author: Aled Sage <al...@gmail.com>
Date: 2016-01-19T12:20:09Z
Fix DynamicFabric locations
- When locations are defined at the YAML top-level, then ensure the
DynamicFabric finds those.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1159#issuecomment-172854511
looks good; will merge, but also have some related follow-on tidies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1159#discussion_r50112095
--- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java ---
@@ -112,9 +115,10 @@ public void start(Collection<? extends Location> locsO) {
if (locsO!=null) {
addLocations(locsO);
}
-
+ Collection<Location> locs = Collections.unmodifiableCollection(Locations.getLocationsCheckingAncestors(getLocations(), this));
--- End diff --
move this into the `newLocations.isEmpty()` condition we only need it it `locs0` is empty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1159#issuecomment-172862425
@johnmccabe i saw the same things, have applied them at #1161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix DynamicFabric locations
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1159#discussion_r50112252
--- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java ---
@@ -18,11 +18,13 @@
*/
package org.apache.brooklyn.entity.group;
+import static com.google.common.base.Preconditions.checkArgument;
--- End diff --
we're already importing `com.google.common.base.Preconditions`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---