You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/26 05:00:03 UTC

[GitHub] [cloudstack] davidjumani edited a comment on pull request #4666: Fix bug in creating shared network

davidjumani edited a comment on pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#issuecomment-807935586


   Might be a bit late to the party, but I think this can be solved better by appending the API result of `addPhysicalNetworkForGuestTrafficType` to an array of promises, and then running a `Promise.all().then()` on the array
   Ref https://github.com/apache/cloudstack/blob/master/ui/src/components/view/SearchView.vue#L262
   
   This way all the apis get resolved and finally in the `Promise.all().then()` the physicalnetwork can be set in the form. This takes care of any async issues that crop up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org