[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3436: Fix the error result when assert num rows node is used

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3436:
URL: https://github.com/apache/incubator-doris/pull/3436#discussion_r417377285



##########
File path: be/src/exec/assert_num_rows_node.cpp
##########
@@ -45,6 +45,7 @@ Status AssertNumRowsNode::prepare(RuntimeState* state) {
 Status AssertNumRowsNode::open(RuntimeState* state) {
     SCOPED_TIMER(_runtime_profile->total_time_counter());
     RETURN_IF_ERROR(ExecNode::open(state));
+    RETURN_IF_ERROR(child(0)->open(state));

Review comment:
       Would better add a comment or this issue link to let other people know why and when to call child(0)->open method. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org