[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4455: Better messages from Janitor on abandoned cache dirs.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on code in PR #4455:
URL: https://github.com/apache/netbeans/pull/4455#discussion_r937617100


##########
platform/janitor/src/org/netbeans/modules/janitor/Janitor.java:
##########
@@ -58,11 +58,34 @@
     "# {1} - the days of abandonement",
     "# {2} - the disk space can be reclaimed (in megabytes)",
     "TIT_ABANDONED_USERDIR=NetBeans {0} was last used {1} days ago.",
+
+    "# {0} - the name of the abandoned cache dir.",
+    "# {1} - the disk space can be reclaimed (in megabytes)",
+    "TIT_ABANDONED_CACHEDIR=NetBeans cache directory {0} seems to be abandoned.",
+
     "# {0} - is the user directory name",
     "# {1} - the days of abandonement",
     "# {2} - the disk space can be reclaimed (in megabytes)",
     "DESC_ABANDONED_USERDIR=Remove unused data and cache directories of NetBeans {0}. "
             + "Free up {2} MB of disk space.",
+
+    "# {0} - is the cache directory name",
+    "# {1} - the disk space can be reclaimed (in megabytes)",
+    "DESC_ABANDONED_CACHEDIR=NetBeans does not found a user dir for "
+            + "cache dir {0}, so it maybe abandoned. "

Review Comment:
   Agree with @mbien - something along lines of "NetBeans could not find a user dir for cache dir {0}, so it is probably abandoned".
   
   At least "maybe" should be "may be" or "might be" - "NetBeans could not find a user dir for cache dir {0}, so it may be abandoned".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists