You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2020/12/24 14:49:16 UTC

[airflow] branch master updated: When CLI changes, we also re-run K8S tests (#13305)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/master by this push:
     new e2bfac9  When CLI changes, we also re-run K8S tests (#13305)
e2bfac9 is described below

commit e2bfac9fc874a6dd1eb52a067313f43ec94307e3
Author: Jarek Potiuk <ja...@polidea.com>
AuthorDate: Thu Dec 24 15:48:57 2020 +0100

    When CLI changes, we also re-run K8S tests (#13305)
    
    Since K8S tests use Airflow CLI (via Helm Chart) we should
    also run the K8S tests when CLI changes.
    
    Fixes #12780
---
 PULL_REQUEST_WORKFLOW.rst         | 3 ++-
 scripts/ci/selective_ci_checks.sh | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PULL_REQUEST_WORKFLOW.rst b/PULL_REQUEST_WORKFLOW.rst
index 23df4d9..ea10488 100644
--- a/PULL_REQUEST_WORKFLOW.rst
+++ b/PULL_REQUEST_WORKFLOW.rst
@@ -154,7 +154,8 @@ The logic implemented for the changes works as follows:
       modifications to any Python code occurs. Example test of this type is verifying proper structure of
       the project including proper naming of all files.
    b) if any of the Airflow API files changed we enable ``API`` test type
-   c) if any of the Airflow CLI files changed we enable ``CLI`` test type
+   c) if any of the Airflow CLI files changed we enable ``CLI`` test type and Kubernetes tests (the
+      K8S tests depend on CLI changes as helm chart uses CLI to run Airflow).
    d) if any of the Provider files changed we enable ``Providers`` test type
    e) if any of the WWW files changed we enable ``WWW`` test type
    f) if any of the Kubernetes files changed we enable ``Kubernetes`` test type
diff --git a/scripts/ci/selective_ci_checks.sh b/scripts/ci/selective_ci_checks.sh
index 04b9f5a..0d119ab 100755
--- a/scripts/ci/selective_ci_checks.sh
+++ b/scripts/ci/selective_ci_checks.sh
@@ -536,9 +536,10 @@ function calculate_test_types_to_run() {
         fi
         if [[ ${COUNT_CLI_CHANGED_FILES} != "0" ]]; then
             echo
-            echo "Adding CLI to selected files as ${COUNT_CLI_CHANGED_FILES} CLI files changed"
+            echo "Adding CLI and Kubernetes (they depend on CLI) to selected files as ${COUNT_CLI_CHANGED_FILES} CLI files changed"
             echo
             SELECTED_TESTS="${SELECTED_TESTS} CLI"
+            kubernetes_tests_needed="true"
         fi
         if [[ ${COUNT_PROVIDERS_CHANGED_FILES} != "0" ]]; then
             echo