[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #148: HDDS-2105. Merge OzoneClientFactory#getRpcClient functions

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #148: HDDS-2105. Merge OzoneClientFactory#getRpcClient functions
URL: https://github.com/apache/hadoop-ozone/pull/148#discussion_r347655711
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
 ##########
 @@ -779,10 +780,12 @@ public void testReadRequest() throws Exception {
       OzoneManager ozoneManager = cluster.getOzoneManager(i);
       String omHostName = ozoneManager.getOmRpcServerAddr().getHostName();
       int rpcPort = ozoneManager.getOmRpcServerAddr().getPort();
+      // Test can pass without this line below
+      conf.set(OZONE_OM_ADDRESS_KEY, omHostName + ":" + rpcPort);
 
 Review comment:
   Also, I think it would be a good idea to check here that after _omFailoverProxyProvider.performFailoverIfRequired(ozoneManager.getOMNodeId());_, the current OM proxy node in FailoverProvider is the expected nodeId.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org