You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by GitBox <gi...@apache.org> on 2021/08/29 22:34:39 UTC

[GitHub] [deltaspike] beikov opened a new pull request #119: DELTASPIKE-1432 Make the impl-asm module a MRJAR with a ClassDefiner that uses MethodHandles.Lookup on Java 9+

beikov opened a new pull request #119:
URL: https://github.com/apache/deltaspike/pull/119


   https://issues.apache.org/jira/browse/DELTASPIKE-1432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [deltaspike] beikov commented on pull request #119: DELTASPIKE-1432 Make the impl-asm module a MRJAR with a ClassDefiner that uses MethodHandles.Lookup on Java 9+

Posted by GitBox <gi...@apache.org>.
beikov commented on pull request #119:
URL: https://github.com/apache/deltaspike/pull/119#issuecomment-912990855


   There you go, a reflection based solution that prefers the class loader definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [deltaspike] tandraschko merged pull request #119: DELTASPIKE-1432 Implement MethodHandles.Lookup based fallback for class definition on Java 9+

Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #119:
URL: https://github.com/apache/deltaspike/pull/119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [deltaspike] rmannibucau commented on pull request #119: DELTASPIKE-1432 Make the impl-asm module a MRJAR with a ClassDefiner that uses MethodHandles.Lookup on Java 9+

Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #119:
URL: https://github.com/apache/deltaspike/pull/119#issuecomment-908048246


   Let's use reflection or a system property controlled switch (java.version by default, a deltaspike specific to force it - using DS config) since mjar have several drawbacks and dont work in post EE servers DS targets.
   
   Side note: we can want to switch to a classloader definition when possible (no package scope method to proxy) which is portable accross all java versions and do not need unsafe hack/workaround.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [deltaspike] beikov commented on pull request #119: DELTASPIKE-1432 Implement MethodHandles.Lookup based fallback for class definition on Java 9+

Posted by GitBox <gi...@apache.org>.
beikov commented on pull request #119:
URL: https://github.com/apache/deltaspike/pull/119#issuecomment-921046171


   Is that fine for you now @rmannibucau ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org