[activemq] branch master updated: [AMQ-7303] Improve logging in case of security exception on transport connection

[jb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git


The following commit(s) were added to refs/heads/master by this push:
     new 945cd6b  [AMQ-7303] Improve logging in case of security exception on transport connection
     new c0e7949  Merge pull request #500 from jbonofre/AMQ-7303
945cd6b is described below

commit 945cd6b7de20cbc0a092eaa2e6dff5dfacc9acc3
Author: jbonofre <jb...@apache.org>
AuthorDate: Wed Mar 4 18:57:02 2020 +0100

    [AMQ-7303] Improve logging in case of security exception on transport connection
---
 .../src/main/java/org/apache/activemq/broker/TransportConnection.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java b/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java
index 70a3741..1f658b6 100644
--- a/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java
+++ b/activemq-broker/src/main/java/org/apache/activemq/broker/TransportConnection.java
@@ -847,7 +847,7 @@ public class TransportConnection implements Connection, Task, CommandVisitor {
                 brokerConnectionStates.remove(info.getConnectionId());
             }
             unregisterConnectionState(info.getConnectionId());
-            LOG.warn("Failed to add Connection id={}, clientId={} due to {}", info.getConnectionId(), clientId, e.getLocalizedMessage(), e);
+            LOG.warn("Failed to add Connection id={}, clientId={}, clientIP={} due to {}", info.getConnectionId(), clientId, info.getClientIp(), e.getLocalizedMessage());
             //AMQ-6561 - stop for all exceptions on addConnection
             // close this down - in case the peer of this transport doesn't play nice
             delayedStop(2000, "Failed with SecurityException: " + e.getLocalizedMessage(), e);