You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/18 21:33:38 UTC

[GitHub] [pinot] mcvsubbu commented on pull request #7782: expose API with git branch and commit info

mcvsubbu commented on pull request #7782:
URL: https://github.com/apache/pinot/pull/7782#issuecomment-973289605


   > > Why not extend the /version URI to provide this information as opposed to introducing a new endpoint? I am also fine with /v2/version if it is not possible to make it backward compatible.
   > 
   > This _does_ extend the /version URI: the URI is /version/commit to get the commit info.
   
   
   
   > > Why not extend the /version URI to provide this information as opposed to introducing a new endpoint? I am also fine with /v2/version if it is not possible to make it backward compatible.
   > 
   > This _does_ extend the /version URI: the URI is /version/commit to get the commit info.
   
   I was thinking to provide a single api that has version and commit info in it, rather than two different apis. We can deprecate/remove the version api eventually. It can be a v2/version for example (or version/v2, whichever way we are versioning -- not sure).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org