You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Two-Hearts (via GitHub)" <gi...@apache.org> on 2023/10/31 09:39:57 UTC

[PR] update: add weak-compatible to dependency check [skywalking-eyes]

Two-Hearts opened a new pull request, #171:
URL: https://github.com/apache/skywalking-eyes/pull/171

   This PR is based on this discussion: https://github.com/apache/skywalking/discussions/11391.
   A new list called `weak-compatible` is added to the [skywalking-eyes compatibility list](https://github.com/apache/skywalking-eyes/blob/main/assets/compatibility/Apache-2.0.yaml). 
   A new flag called `weak-compatible` is added to the `dependency check` command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update: add weak-compatible to dependency check [skywalking-eyes]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #171:
URL: https://github.com/apache/skywalking-eyes/pull/171#issuecomment-1786863436

   Thanks for raising this. Please fix the CI first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update: add weak-compatible to dependency check [skywalking-eyes]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #171:
URL: https://github.com/apache/skywalking-eyes/pull/171#discussion_r1377508303


##########
commands/deps_check.go:
##########
@@ -26,6 +26,12 @@ import (
 	"github.com/apache/skywalking-eyes/pkg/deps"
 )
 
+var weakCompatible bool
+
+func init() {
+	DepsCheckCommand.PersistentFlags().BoolVarP(&weakCompatible, "weak-compatible", "w", false, "if set, include the weak-compatible list in dependencies checking")

Review Comment:
   To me, "include the weak-compatible list in dependencies checking" doesn't indicate the "checking" accepts or rejects the list in dependencies, which might be ambiguous for users, what do you think if we make it more explicit in the description, and add a note, for example:
   
   if set to true, treat the `weak-compatible` licenses as compatible in dependencies check. Note: when set this to true, make sure to manually confirm that you are using the `weak-compatible` licenses under the required conditions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update: add weak-compatible to dependency check [skywalking-eyes]

Posted by "Two-Hearts (via GitHub)" <gi...@apache.org>.
Two-Hearts commented on code in PR #171:
URL: https://github.com/apache/skywalking-eyes/pull/171#discussion_r1378346918


##########
commands/deps_check.go:
##########
@@ -26,6 +26,12 @@ import (
 	"github.com/apache/skywalking-eyes/pkg/deps"
 )
 
+var weakCompatible bool
+
+func init() {
+	DepsCheckCommand.PersistentFlags().BoolVarP(&weakCompatible, "weak-compatible", "w", false, "if set, include the weak-compatible list in dependencies checking")

Review Comment:
   Thanks @kezhenxu94, I updated the description based on your example. CI fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update: add weak-compatible to dependency check [skywalking-eyes]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #171:
URL: https://github.com/apache/skywalking-eyes/pull/171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] update: add weak-compatible to dependency check [skywalking-eyes]

Posted by "Two-Hearts (via GitHub)" <gi...@apache.org>.
Two-Hearts commented on PR #171:
URL: https://github.com/apache/skywalking-eyes/pull/171#issuecomment-1786874139

   Working on the CI, looks like a lint problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org