[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #10344: [Tests] Remove ".atMost" definitions for Awaitility in most cases

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #10344:
URL: https://github.com/apache/pulsar/pull/10344#discussion_r619587579



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -2194,7 +2194,7 @@ public void testPersistentTopicsExpireMessages() throws Exception {
         Thread.sleep(1000);
         admin.topics().expireMessages("persistent://prop-xyz/ns1/ds2", "my-sub1", 1);
         // Wait at most 2 seconds for sub1's message to expire.

Review comment:
       It's probably worth updating this comment, as the wait is now the default setting instead of the specified 2 seconds.

##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -2229,7 +2229,7 @@ public void testPersistentTopicsExpireMessages() throws Exception {
             assertTrue(e.getMessage().startsWith("Expire message by timestamp not issued on topic"));
         }
         // Wait at most 2 seconds for sub3's message to expire.

Review comment:
       Same point about time difference here.

##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -2209,7 +2209,7 @@ public void testPersistentTopicsExpireMessages() throws Exception {
         admin.topics().expireMessages("persistent://prop-xyz/ns1/ds2", "my-sub2",
                 messageIds.get(4), false);
         // Wait at most 2 seconds for sub2's message to expire.

Review comment:
       Same point about time difference here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org