You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 13:55:05 UTC
[GitHub] [skywalking-infra-e2e] kezhenxu94 opened a new pull request #1: Remove ignored file and set license-eye
kezhenxu94 opened a new pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] Humbertzhang commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
Humbertzhang commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752089852
Maybe a licenserc.yaml should be added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752097796
> even we have a release of license-eye, it's a good practice to use a commit hash instead of a tag
Could you share the reason of this suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752106941
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752095577
The `.asf.yaml` should work now (it was still `default branch==master` in gitbox and the infra just update that for us)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752101074
> > even we have a release of license-eye, it's a good practice to use a commit hash instead of a tag
>
> Could you share the reason of this suggestion?
Because tags can be modified (e.g. you can push malicious codes and retag), https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/finding-and-customizing-actions#using-shas this is also recommended by the infra team during the recent security issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 merged pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] Humbertzhang removed a comment on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
Humbertzhang removed a comment on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752089852
Maybe a licenserc.yaml should be added?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #1: Remove ignored file and set license-eye
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1:
URL: https://github.com/apache/skywalking-infra-e2e/pull/1#issuecomment-752094200
I use a commit hash in the license-eye action, I think this can be merged for now as
1. we don't need a release of license-eye in order to use it HERE
2. even we have a release of license-eye, it's a good practice to use a commit hash instead of a tag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org