You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/16 10:21:23 UTC

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

rajinisivaram commented on a change in pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#discussion_r471094493



##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None, use_zk_to_create_topic=True):
         self.logger.info("Running topic creation command...\n%s" % cmd)
         node.account.ssh(cmd)
 
-    def delete_topic(self, topic, node=None):
+    def delete_topic(self, topic, node=None, use_zk_to_delete_topic=False):

Review comment:
       @rondagostino are we ok with merging this to trunk? Since this is not required for existing tests which either use ZK or PLAINTEXT brokers, not planning to backport to older versions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org