[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5743: HDFS-17049. EC: Fix duplicate block group IDs generated by SequentialBlockGroupIdGenerator.

["zhangshuyan0 (via GitHub)" <gi...@apache.org>]

zhangshuyan0 commented on code in PR #5743:
URL: https://github.com/apache/hadoop/pull/5743#discussion_r1229201352


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SequentialBlockGroupIdGenerator.java:
##########
@@ -51,7 +51,7 @@ public class SequentialBlockGroupIdGenerator extends SequentialNumber {
   }
 
   @Override // NumberGenerator
-  public long nextValue() {
+  synchronized public long nextValue() {

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org