[GitHub] dawidwys edited a comment on issue #7110: [FLINK-8159] [cep] Pattern(Flat)SelectFunctions should support RichFunction interface

[GitBox <gi...@apache.org>]

dawidwys edited a comment on issue #7110: [FLINK-8159] [cep] Pattern(Flat)SelectFunctions should support RichFunction interface
URL: https://github.com/apache/flink/pull/7110#issuecomment-441666754
 
 
   Hi @dianfu,
   Just a few comments, before we are ready to go with this PR:
   
   1. Let's deprecate `OrCondition`, `AndCondition`, `NotCondition` with a comment that they exist only for backwards compatibility and advice to use the rich versions. (Agreed, let's do this in a separate PR/issue: https://issues.apache.org/jira/browse/FLINK-10113)
   2. Mark all the conditions in `conditions` package `@Internal`
   3. I would be in favor of unifying the null handling in the new classes in a way that we do not allow nulls there. We can change the `getCondition` method in `Pattern` to return `BooleanConditions#trueFunction` if nothing was set. This will make the whole logic more explicit IMHO. Let's leave the old classes as they are, as we want to drop them anyway.
   4. Use the new rich conditions in `Pattern#where` and `Pattern#or`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services