You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/07 00:07:09 UTC

[GitHub] [iceberg] rdblue commented on pull request #6128: Python: Projection

rdblue commented on PR #6128:
URL: https://github.com/apache/iceberg/pull/6128#issuecomment-1304935137

   This is looking great. There are just two issues:
   1. The date/time transforms should use the same logic as truncate for numbers since they're basically truncating
   2. I don't think that the changes to expressions are necessary
   
   Thanks, @Fokko!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org