You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/20 13:01:46 UTC

[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #13210: [Improvement][all] Field injection is not recommended Inspection info: Spring Team recommends: "Always use constructor based dependency injection in your beans. Always use assertions for mandatory dependencies".

DarkAssassinator commented on issue #13210:
URL: https://github.com/apache/dolphinscheduler/issues/13210#issuecomment-1359319513

   this is just a IDEA warnning, but i do think that construct will better than`@Autowired`, In terms of readability, `@Autowired` is better, and if we will inject many beans, o huge constuct may not be a good idea. WDYT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org