You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2019/02/01 08:26:22 UTC

Re: [httpcomponents-client] branch master updated: Use final.

On Fri, 2019-02-01 at 02:11 +0000, ggregory@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> ggregory pushed a commit to branch master
> in repository 
> https://gitbox.apache.org/repos/asf/httpcomponents-client.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
>      new 1f06087  Use final.
> 1f06087 is described below
> 
> commit 1f06087fad17af936273555f2dbaaf79563bf0a2
> Author: Gary Gregory <gg...@rocketsoftware.com>
> AuthorDate: Thu Jan 31 21:11:28 2019 -0500
> 
>     Use final.

Gary,

Could you please make changes on a development branch first? Could you
also please avoid those one liner commits in general? If you want to
change code style of certain classes could you please make
_consistently_ across the entire code base?
 
Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org