[GitHub] [fineract] vidakovic commented on pull request #2023: FINERACT-1490: SSL configuration based on application.properties

[GitBox <gi...@apache.org>]

vidakovic commented on pull request #2023:
URL: https://github.com/apache/fineract/pull/2023#issuecomment-1057525867


   @francisguchie no problem at all... and as long as the community wants/needs a WAR file there will be one... in between releases 1.5 and 1.6 there was just a short moment when the WAR build was not properly working, but those issues are fixed. Things will get even easier once we have full Testcontainer support (working on it) which will replace the Cargo plugin based integration testing that we currently have. 
   
   Here's another idea: in those Testcontainer unit tests we could also do - kind of - integration tests that cover WAR deployments in multiple application containers like Jetty, Tomcat, Undertow, JBoss... at least to show that the WAR is properly started in those environments... have to think about this... wondering if the community would like to use something else than Tomcat?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org