[GitHub] [skywalking] pg-yang commented on a diff in pull request #9514: Update alarm doc introduce configuration property key

[GitBox <gi...@apache.org>]

pg-yang commented on code in PR #9514:
URL: https://github.com/apache/skywalking/pull/9514#discussion_r952679754


##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -348,3 +348,23 @@ which will override the settings in `alarm-settings.yml`.
 In order to determine whether an alerting rule is triggered or not, SkyWalking needs to cache the metrics of a time window for
 each alerting rule. If any attribute (`metrics-name`, `op`, `threshold`, `period`, `count`, etc.) of a rule is changed,
 the sliding window will be destroyed and re-created, causing the Alarm of this specific rule to restart again.
+
+### Configuration property key of Alerting element

Review Comment:
   [RulesReader](https://github.com/apache/skywalking/blob/master/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java#L85)
   
   There is no doc list these key  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org