You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/09 22:10:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #7673: [AIRFLOW-7015]
Detect Dockerhub repo/user when building on Dockerhub
potiuk opened a new pull request #7673: [AIRFLOW-7015] Detect Dockerhub repo/user when building on Dockerhub
URL: https://github.com/apache/airflow/pull/7673
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7673: [AIRFLOW-7015] Detect
Dockerhub repo/user when building on Dockerhub
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7673: [AIRFLOW-7015] Detect Dockerhub repo/user when building on Dockerhub
URL: https://github.com/apache/airflow/pull/7673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7673: [AIRFLOW-7015]
Detect Dockerhub repo/user when building on Dockerhub
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7673: [AIRFLOW-7015] Detect Dockerhub repo/user when building on Dockerhub
URL: https://github.com/apache/airflow/pull/7673#issuecomment-596845065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=h1) Report
> Merging [#7673](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/29e848d846e4fb5006ad3494d8a50d69129f41c6?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7673 +/- ##
==========================================
+ Coverage 86.82% 86.95% +0.12%
==========================================
Files 897 900 +3
Lines 42869 43603 +734
==========================================
+ Hits 37223 37913 +690
- Misses 5646 5690 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...irflow/providers/google/cloud/hooks/datacatalog.py](https://codecov.io/gh/apache/airflow/pull/7673/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2RhdGFjYXRhbG9nLnB5) | `91.74% <0%> (ø)` | |
| [...ow/providers/google/cloud/operators/datacatalog.py](https://codecov.io/gh/apache/airflow/pull/7673/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhY2F0YWxvZy5weQ==) | `93.41% <0%> (ø)` | |
| [...s/google/cloud/example\_dags/example\_datacatalog.py](https://codecov.io/gh/apache/airflow/pull/7673/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RhdGFjYXRhbG9nLnB5) | `100% <0%> (ø)` | |
| [airflow/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7673/diff?src=pr&el=tree#diff-YWlyZmxvdy9fX2luaXRfXy5weQ==) | `100% <0%> (+8%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=footer). Last update [29e848d...a675b03](https://codecov.io/gh/apache/airflow/pull/7673?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7673: [AIRFLOW-7015] Detect
Dockerhub repo/user when building on Dockerhub
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7673: [AIRFLOW-7015] Detect Dockerhub repo/user when building on Dockerhub
URL: https://github.com/apache/airflow/pull/7673#issuecomment-596804317
Simpler and restoring building on dockerhub
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services