You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Xinyu Liu (JIRA)" <ji...@apache.org> on 2016/07/29 19:55:20 UTC

[jira] [Updated] (SAMZA-982) Add null check for offset update in OffsetManager

     [ https://issues.apache.org/jira/browse/SAMZA-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xinyu Liu updated SAMZA-982:
----------------------------
    Attachment: SAMZA-982.0.patch

> Add null check for offset update in OffsetManager
> -------------------------------------------------
>
>                 Key: SAMZA-982
>                 URL: https://issues.apache.org/jira/browse/SAMZA-982
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.11
>            Reporter: Xinyu Liu
>            Assignee: Xinyu Liu
>            Priority: Blocker
>         Attachments: SAMZA-982.0.patch
>
>
> During the process of making offsetManager thread-safe, I changed the impl of lastProcessedOffsets to use ConcurrentHashMap. However, I didn't realize offset can be null so it will trigger null pointer exception when ConcurrentHashMap.put(key, null). The fix will add the null check so null offset will be still supported such as in our hello-samza example.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)