You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/07/27 15:03:22 UTC
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1046: [#363] refactor: Make the coordinator client managed by CoordinatorClientFactory singleton
codecov-commenter commented on PR #1046:
URL: https://github.com/apache/incubator-uniffle/pull/1046#issuecomment-1653807811
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1046](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (883fa84) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/16942c21b9e1fad070a3ff1fa313c6f93f2bedc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (16942c2) will **increase** coverage by `0.25%`.
> The diff coverage is `16.12%`.
```diff
@@ Coverage Diff @@
## master #1046 +/- ##
============================================
+ Coverage 54.33% 54.58% +0.25%
+ Complexity 2550 2401 -149
============================================
Files 382 345 -37
Lines 21739 18244 -3495
Branches 1803 1717 -86
============================================
- Hits 11811 9958 -1853
+ Misses 9227 7692 -1535
+ Partials 701 594 -107
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...iffle/client/factory/CoordinatorClientFactory.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9mYWN0b3J5L0Nvb3JkaW5hdG9yQ2xpZW50RmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `35.98% <50.00%> (ø)` | |
| [...a/org/apache/uniffle/server/RegisterHeartBeat.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9SZWdpc3RlckhlYXJ0QmVhdC5qYXZh) | `88.13% <100.00%> (+0.20%)` | :arrow_up: |
... and [39 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1046/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org