You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/03/04 18:51:42 UTC

DO NOT REPLY [Bug 44531] New: underline-position in font-face has wrong sign

https://issues.apache.org/bugzilla/show_bug.cgi?id=44531

           Summary: underline-position in font-face has wrong sign
           Product: Batik
           Version: 1.7
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: GVT Text
        AssignedTo: batik-dev@xmlgraphics.apache.org
        ReportedBy: markus+asf@gyger.org


Created an attachment (id=21625)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21625)
SVG font with underline and overline text example

Attribute underline-position of element <font-face> seems to get negatived (-).
Compared to attributes overline-position and strikethrough-position, this
appears as unexpected. Apparently none of the SVG test fonts use
underline-position and the default value looks fine. See
getLineMetrics(int,int) in SVGGVTFont.java for the assignment to ulOffset
without - in front of variable scale.

It might also be nice if stroke-width of underline would scale with font-size.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 44531] underline-position in font-face has wrong sign

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44531


mg <ma...@gyger.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |45598




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 44531] underline-position in font-face has wrong sign

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44531


dipen <di...@eetpl.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P3




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 44531] underline-position in font-face has wrong sign

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44531





--- Comment #1 from Helder Magalhães <he...@gmail.com>  2009-07-19 15:57:36 PST ---
Created an attachment (id=24006)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24006)
Patch from proposal

(In reply to comment #0)
> Attribute underline-position of element <font-face> seems to get negatived (-).
> Compared to attributes overline-position and strikethrough-position, this
> appears as unexpected. Apparently none of the SVG test fonts use
> underline-position and the default value looks fine.

After investigating a bit, I've found that
"samples/tests/spec/fonts/fontDecorations.svg" does use underline in a SVG font
and, although no specific value is given to the "underline-position" property,
just using underline seems to be enough (so I'd argue on the default value
looking fine statement). ;-)


> See getLineMetrics(int,int) in SVGGVTFont.java for the assignment to ulOffset
> without - in front of variable scale.

The attached patch does exactly that. :-)  Fixes the attached test case and
also improves look in "fontDecorations.svg". ;-)


> It might also be nice if stroke-width of underline would scale with font-size.

By taking a look at the source code and performing a quick test, it seems that
it's already being done. Thing is the test case attached to this bug report
uses a zero-width stroke, which intuitively would not scale (but I haven't
double checked the specification regarding this; I'm not even sure if
zero-width strokes should render...).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 44531] [PATCH] underline-position in font-face has wrong sign

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44531


Helder Magalhães <he...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
           Platform|PC                          |All
            Version|1.7                         |1.8
            Summary|underline-position in       |[PATCH] underline-position
                   |font-face has wrong sign    |in font-face has wrong sign
         OS/Version|Windows XP                  |All
           Severity|normal                      |minor




--- Comment #2 from Helder Magalhães <he...@gmail.com>  2009-07-19 16:00:20 PST ---
(Updating metadata to reflect a patch being available; Also, taking the
opportunity to update a few bug properties.)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 44531] [PATCH] underline-position in font-face has wrong sign

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44531





--- Comment #3 from mg <ma...@gyger.org>  2009-07-22 07:32:22 PST ---
Thanks!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org