You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Yegor Kozlov <ye...@dinom.ru> on 2011/02/04 14:22:08 UTC
ExcelAnt contribution
Hi All,
I started reviewing the ExcelAnt contribution (see Bugzilla #50610 and
http://www.github/jsvede/excelant).
The code is very cool, but I would like to clarify two things before I
apply it:
(1) ExcelAnt depends on ant.jar. Are we OK to include it in the
compilation classpath? It is a compile-time dependency, ant.jar is
needed only to compile the new Ant tasks and will not be included in POI
distributions.
(2) What is the proper place for this code? I propose poi-scratchpad,
later we can move it to poi-main.
Regards,
Yegor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 4 Feb 2011, Jon Svede wrote:
> I am going to update the ticket with the latest code which will include
> the tests that I have.
Great
> The excelant.util package is probably the most important package for
> test coverage and that is at 40% right now.
The package name should probably change to something like
org.apache.poi.ant - Yegor would you agree?
> It sounds like Yegor/Nick are going to do the build integration? Or do
> you want me to take a stab at it based on this thread? I am happy to
> give it a shot.
If no-one has done it by late next week, I ought to have some time to pull
it together
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Jon Svede <js...@yahoo.com>.
I am going to update the ticket with the latest code which will include the
tests that I have.
The excelant.util package is probably the most important package for test
coverage and that is at 40% right now.
It sounds like Yegor/Nick are going to do the build integration? Or do you want
me to take a stab at it based on this thread? I am happy to give it a shot.
Jon
________________________________
From: Yegor Kozlov <ye...@dinom.ru>
To: dev@poi.apache.org
Sent: Fri, February 4, 2011 9:54:21 AM
Subject: Re: ExcelAnt contribution
25% code coverage is fine for now. 70% would be excellent.
Yegor
On 2/4/2011 6:08 PM, Jon Svede wrote:
> I don't know if this matters with respect to committing the patch but I am
>still
> working on getting more test coverage, I am about 25% code coverage right now.
> I'd like to get that number up to at least 70%.
>
>
> I have not spent any time on the build integration yet, it's on my list of
> things to do right after the tests.
>
> Sincerely,
>
> Jon
>
>
> From: Nick Burch<ni...@alfresco.com>
>
> To: POI Developers List<de...@poi.apache.org>
> Cc: jsvede@yahoo.com
> Sent: Fri, February 4, 2011 6:27:08 AM
> Subject: Re: ExcelAnt contribution
>
> On Fri, 4 Feb 2011, Yegor Kozlov wrote:
>> (1) ExcelAnt depends on ant.jar. Are we OK to include it in the compilation
>> classpath? It is a compile-time dependency, ant.jar is needed only to compile
>> the new Ant tasks and will not be included in POI distributions.
> I think we should put the code into its own jar. The ant jar is then only
>needed
> as a dependency when building that jar, so people can always exclude that
>target
> if they want
>
>> (2) What is the proper place for this code? I propose poi-scratchpad, later
we
>> can move it to poi-main.
> I think it needs to be in its own jar. It has a dependency on ant, and I don't
> think we want to add that dependency to any of the current, widely used jars.
>
> One thing we could perhaps do is provide an ant task that generates a single
> huge "poi-for-ant" jar which includes all the dependencies to make the install
> easier.
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Yegor Kozlov <ye...@dinom.ru>.
25% code coverage is fine for now. 70% would be excellent.
Yegor
On 2/4/2011 6:08 PM, Jon Svede wrote:
> I don't know if this matters with respect to committing the patch but I am still
> working on getting more test coverage, I am about 25% code coverage right now.
> I'd like to get that number up to at least 70%.
>
>
> I have not spent any time on the build integration yet, it's on my list of
> things to do right after the tests.
>
> Sincerely,
>
> Jon
>
>
> From: Nick Burch<ni...@alfresco.com>
>
> To: POI Developers List<de...@poi.apache.org>
> Cc: jsvede@yahoo.com
> Sent: Fri, February 4, 2011 6:27:08 AM
> Subject: Re: ExcelAnt contribution
>
> On Fri, 4 Feb 2011, Yegor Kozlov wrote:
>> (1) ExcelAnt depends on ant.jar. Are we OK to include it in the compilation
>> classpath? It is a compile-time dependency, ant.jar is needed only to compile
>> the new Ant tasks and will not be included in POI distributions.
> I think we should put the code into its own jar. The ant jar is then only needed
> as a dependency when building that jar, so people can always exclude that target
> if they want
>
>> (2) What is the proper place for this code? I propose poi-scratchpad, later we
>> can move it to poi-main.
> I think it needs to be in its own jar. It has a dependency on ant, and I don't
> think we want to add that dependency to any of the current, widely used jars.
>
> One thing we could perhaps do is provide an ant task that generates a single
> huge "poi-for-ant" jar which includes all the dependencies to make the install
> easier.
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Jon Svede <js...@yahoo.com>.
I don't know if this matters with respect to committing the patch but I am still
working on getting more test coverage, I am about 25% code coverage right now.
I'd like to get that number up to at least 70%.
I have not spent any time on the build integration yet, it's on my list of
things to do right after the tests.
Sincerely,
Jon
From: Nick Burch <ni...@alfresco.com>
To: POI Developers List <de...@poi.apache.org>
Cc: jsvede@yahoo.com
Sent: Fri, February 4, 2011 6:27:08 AM
Subject: Re: ExcelAnt contribution
On Fri, 4 Feb 2011, Yegor Kozlov wrote:
> (1) ExcelAnt depends on ant.jar. Are we OK to include it in the compilation
>classpath? It is a compile-time dependency, ant.jar is needed only to compile
>the new Ant tasks and will not be included in POI distributions.
I think we should put the code into its own jar. The ant jar is then only needed
as a dependency when building that jar, so people can always exclude that target
if they want
> (2) What is the proper place for this code? I propose poi-scratchpad, later we
>can move it to poi-main.
I think it needs to be in its own jar. It has a dependency on ant, and I don't
think we want to add that dependency to any of the current, widely used jars.
One thing we could perhaps do is provide an ant task that generates a single
huge "poi-for-ant" jar which includes all the dependencies to make the install
easier.
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 4 Feb 2011, David Fisher wrote:
>> Also, do we need the full ant jar, or is there a smaller interface jar
>> for people compiling extensions that we could link against?
>
> If someone is using the ExcelAnt tool then they will be using Ant and
> should have the ant.jar and all of ant installed already, or am I
> missing something?
It's for people compiling poi, rather than those using the ant extension,
where a smaller jar to build against would be nice
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by David Fisher <df...@jmlafferty.com>.
>> I agree. I've just realized that putting it in poi-main will affect Maven distribution and we will have to add an Ant dependency in poi-main.pom. Are you OK with ant.jar in the lib directory and the sources in src/excelant relative to the project root? This way ExcelAnt will be a normal sub-project, like scratchpad and contrib.
>
> Yup, that's fine for me. We already have the ooxml sub-project with extra dependencies, so I think we could do this along the same lines.
>
> Also, do we need the full ant jar, or is there a smaller interface jar for people compiling extensions that we could link against?
If someone is using the ExcelAnt tool then they will be using Ant and should have the ant.jar and all of ant installed already, or am I missing something?
Regards,
Dave
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 4 Feb 2011, Yegor Kozlov wrote:
> Looks like we will have to use the big ant.jar. I don't see a smaller
> interface jar in public repositories.
It'll add 2mb to our source tarball, and 2mb to what you have to have
downloaded for you when you first use ant to build, but that's probably
not the end of the world
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Yegor Kozlov <ye...@dinom.ru>.
Ignore my previous post, it was a slip of my thumb.
Looks like we will have to use the big ant.jar. I don't see a smaller
interface jar in public repositories.
Yegor
On 2/4/2011 7:56 PM, Yegor Kozlov wrote:
>
> On 2/4/2011 7:51 PM, Nick Burch wrote:
>> On Fri, 4 Feb 2011, Yegor Kozlov wrote:
>>> I agree. I've just realized that putting it in poi-main will affect
>>> Maven distribution and we will have to add an Ant dependency in
>>> poi-main.pom. Are you OK with ant.jar in the lib directory and the
>>> sources in src/excelant relative to the project root? This way
>>> ExcelAnt will be a normal sub-project, like scratchpad and contrib.
>>
>> Yup, that's fine for me. We already have the ooxml sub-project with
>> extra dependencies, so I think we could do this along the same lines.
>>
>> Also, do we need the full ant jar, or is there a smaller interface
>> jar for people compiling extensions that we could link against?
>>
>
> I nee dto check.
>
>> Nick
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Yegor Kozlov <ye...@dinom.ru>.
On 2/4/2011 7:51 PM, Nick Burch wrote:
> On Fri, 4 Feb 2011, Yegor Kozlov wrote:
>> I agree. I've just realized that putting it in poi-main will affect
>> Maven distribution and we will have to add an Ant dependency in
>> poi-main.pom. Are you OK with ant.jar in the lib directory and the
>> sources in src/excelant relative to the project root? This way
>> ExcelAnt will be a normal sub-project, like scratchpad and contrib.
>
> Yup, that's fine for me. We already have the ooxml sub-project with
> extra dependencies, so I think we could do this along the same lines.
>
> Also, do we need the full ant jar, or is there a smaller interface jar
> for people compiling extensions that we could link against?
>
I nee dto check.
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 4 Feb 2011, Yegor Kozlov wrote:
> I agree. I've just realized that putting it in poi-main will affect
> Maven distribution and we will have to add an Ant dependency in
> poi-main.pom. Are you OK with ant.jar in the lib directory and the
> sources in src/excelant relative to the project root? This way ExcelAnt
> will be a normal sub-project, like scratchpad and contrib.
Yup, that's fine for me. We already have the ooxml sub-project with extra
dependencies, so I think we could do this along the same lines.
Also, do we need the full ant jar, or is there a smaller interface jar for
people compiling extensions that we could link against?
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Yegor Kozlov <ye...@dinom.ru>.
On 2/4/2011 4:27 PM, Nick Burch wrote:
> On Fri, 4 Feb 2011, Yegor Kozlov wrote:
>> (1) ExcelAnt depends on ant.jar. Are we OK to include it in the
>> compilation classpath? It is a compile-time dependency, ant.jar is
>> needed only to compile the new Ant tasks and will not be included in
>> POI distributions.
>
> I think we should put the code into its own jar. The ant jar is then
> only needed as a dependency when building that jar, so people can
> always exclude that target if they want
>
I agree. I've just realized that putting it in poi-main will affect
Maven distribution and we will have to add an Ant dependency in
poi-main.pom.
Are you OK with ant.jar in the lib directory and the sources in
src/excelant relative to the project root? This way ExcelAnt will be a
normal sub-project, like scratchpad and contrib.
Yegor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: ExcelAnt contribution
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 4 Feb 2011, Yegor Kozlov wrote:
> (1) ExcelAnt depends on ant.jar. Are we OK to include it in the
> compilation classpath? It is a compile-time dependency, ant.jar is
> needed only to compile the new Ant tasks and will not be included in POI
> distributions.
I think we should put the code into its own jar. The ant jar is then only
needed as a dependency when building that jar, so people can always
exclude that target if they want
> (2) What is the proper place for this code? I propose poi-scratchpad,
> later we can move it to poi-main.
I think it needs to be in its own jar. It has a dependency on ant, and I
don't think we want to add that dependency to any of the current, widely
used jars.
One thing we could perhaps do is provide an ant task that generates a
single huge "poi-for-ant" jar which includes all the dependencies to make
the install easier.
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org