You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2010/05/27 16:58:38 UTC
[jira] Created: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
--------------------------------------------------------------------------------------
Key: SLING-1534
URL: https://issues.apache.org/jira/browse/SLING-1534
Project: Sling
Issue Type: Improvement
Components: Commons
Reporter: Justin Edelson
Fix For: Commons Auth 1.0.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873692#action_12873692 ]
Carsten Ziegeler commented on SLING-1534:
-----------------------------------------
Forgot to add: having a getUserId or getUserID method looks fine to me as well
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-1534:
----------------------------------
Attachment: SLING-1534.patch
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872248#action_12872248 ]
Justin Edelson commented on SLING-1534:
---------------------------------------
patch. doesn't get rid of ALL JCR references, but I think it is as close as we can get without breaking backwards compat.
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1534:
-------------------------------------
Component/s: Authentication
(was: Commons)
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Auth Core 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873691#action_12873691 ]
Carsten Ziegeler commented on SLING-1534:
-----------------------------------------
We could use the user from the authinfo (and pass the auth info into the setAttributes method)
I'm not sure if we have cases where the user from the authinfo is different from the user of the session *and* if in these cases, the session user should be used?
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-1534.
------------------------------------
Close after release
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Auth Core 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873780#action_12873780 ]
Justin Edelson commented on SLING-1534:
---------------------------------------
> I'm not sure if we have cases where the user from the authinfo is different from the user of the session *and* if in these cases, the
> session user should be used?
The only case I can think of (and the reason for the TODO comment) is the anonymous case where authinfo is null. So I think going back to the ResourceResolver/Session is the best thing to do.
I haven't had a chance to apply this patch; will do so in the next day.
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874059#action_12874059 ]
Justin Edelson commented on SLING-1534:
---------------------------------------
done in r950104
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-1534.
-----------------------------------
Assignee: Justin Edelson
Resolution: Fixed
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873125#action_12873125 ]
Felix Meschberger commented on SLING-1534:
------------------------------------------
Patch looks good to me.
> + // TODO - figure out if this can be change to use authInfo instead of the session
> request.setAttribute(HttpContext.REMOTE_USER, session.getUserID());
How about adding a ResourceResolver.getUserID() (or similar) method, which may in the case of JCR be implemented in terms of Session.getUserID() ?
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1534) switch SlingAuthenticator to use
ResourceResolverFactory API rather than JCR directory
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873142#action_12873142 ]
Justin Edelson commented on SLING-1534:
---------------------------------------
I'll create a separate issue for ResourceResolver.getUserID().
> switch SlingAuthenticator to use ResourceResolverFactory API rather than JCR directory
> --------------------------------------------------------------------------------------
>
> Key: SLING-1534
> URL: https://issues.apache.org/jira/browse/SLING-1534
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Reporter: Justin Edelson
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING-1534.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.