You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2016/04/13 14:49:36 UTC
lucene-solr:branch_6x: LUCENE-7205: Remove repeated nl.getLength()
calls in (Boolean|DisjunctionMax|FuzzyLikeThis)QueryBuilder.
Repository: lucene-solr
Updated Branches:
refs/heads/branch_6x ca83f6043 -> 87d7de0d9
LUCENE-7205: Remove repeated nl.getLength() calls in (Boolean|DisjunctionMax|FuzzyLikeThis)QueryBuilder.
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/87d7de0d
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/87d7de0d
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/87d7de0d
Branch: refs/heads/branch_6x
Commit: 87d7de0d9892eab8462f08b876af3481f5b0ccc3
Parents: ca83f60
Author: Christine Poerschke <cp...@apache.org>
Authored: Wed Apr 13 11:27:17 2016 +0100
Committer: Christine Poerschke <cp...@apache.org>
Committed: Wed Apr 13 13:31:09 2016 +0100
----------------------------------------------------------------------
lucene/CHANGES.txt | 3 +++
.../lucene/queryparser/xml/builders/BooleanQueryBuilder.java | 3 ++-
.../queryparser/xml/builders/DisjunctionMaxQueryBuilder.java | 3 ++-
.../queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java | 3 ++-
4 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87d7de0d/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 1915377..3b5dac7 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -77,6 +77,9 @@ Other
* LUCENE-7174: Upgrade randomizedtesting to 2.3.4. (Uwe Schindler, Dawid Weiss)
+* LUCENE-7205: Remove repeated nl.getLength() calls in
+ (Boolean|DisjunctionMax|FuzzyLikeThis)QueryBuilder. (Christine Poerschke)
+
======================= Lucene 6.0.0 =======================
System Requirements
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87d7de0d/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BooleanQueryBuilder.java
----------------------------------------------------------------------
diff --git a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BooleanQueryBuilder.java b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BooleanQueryBuilder.java
index 1dd859c..fbd678b 100644
--- a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BooleanQueryBuilder.java
+++ b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BooleanQueryBuilder.java
@@ -49,7 +49,8 @@ public class BooleanQueryBuilder implements QueryBuilder {
bq.setMinimumNumberShouldMatch(DOMUtils.getAttribute(e, "minimumNumberShouldMatch", 0));
NodeList nl = e.getChildNodes();
- for (int i = 0; i < nl.getLength(); i++) {
+ final int nlLen = nl.getLength();
+ for (int i = 0; i < nlLen; i++) {
Node node = nl.item(i);
if (node.getNodeName().equals("Clause")) {
Element clauseElem = (Element) node;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87d7de0d/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DisjunctionMaxQueryBuilder.java
----------------------------------------------------------------------
diff --git a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DisjunctionMaxQueryBuilder.java b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DisjunctionMaxQueryBuilder.java
index 8490667..0dc9e05 100644
--- a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DisjunctionMaxQueryBuilder.java
+++ b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DisjunctionMaxQueryBuilder.java
@@ -49,7 +49,8 @@ public class DisjunctionMaxQueryBuilder implements QueryBuilder {
List<Query> disjuncts = new ArrayList<>();
NodeList nl = e.getChildNodes();
- for (int i = 0; i < nl.getLength(); i++) {
+ final int nlLen = nl.getLength();
+ for (int i = 0; i < nlLen; i++) {
Node node = nl.item(i);
if (node instanceof Element) { // all elements are disjuncts.
Element queryElem = (Element) node;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87d7de0d/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java
----------------------------------------------------------------------
diff --git a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java
index f969a66..e7e9ad3 100644
--- a/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java
+++ b/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/FuzzyLikeThisQueryBuilder.java
@@ -50,7 +50,8 @@ public class FuzzyLikeThisQueryBuilder implements QueryBuilder {
FuzzyLikeThisQuery fbq = new FuzzyLikeThisQuery(maxNumTerms, analyzer);
fbq.setIgnoreTF(DOMUtils.getAttribute(e, "ignoreTF", DEFAULT_IGNORE_TF));
- for (int i = 0; i < nl.getLength(); i++) {
+ final int nlLen = nl.getLength();
+ for (int i = 0; i < nlLen; i++) {
Element fieldElem = (Element) nl.item(i);
float minSimilarity = DOMUtils.getAttribute(fieldElem, "minSimilarity", DEFAULT_MIN_SIMILARITY);
int prefixLength = DOMUtils.getAttribute(fieldElem, "prefixLength", DEFAULT_PREFIX_LENGTH);