You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/03/19 00:11:13 UTC
[PR] [SLM] Allow TensorStructInfo to specify parameter in export [tvm]
Lunderberg opened a new pull request, #16737:
URL: https://github.com/apache/tvm/pull/16737
Prior to this commit, the parameter specification for SLM tensor needed to be passed as a `nn.spec.Tensor`. As this object is only used to construct a `relax.TensorStructInfo`, and has the same fields as a `relax.TensorStructInfo`, this commit allows the parameter specification to be passed as a `relax.TensorStructInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SLM] Allow TensorStructInfo to specify parameter in export [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg closed pull request #16737: [SLM] Allow TensorStructInfo to specify parameter in export
URL: https://github.com/apache/tvm/pull/16737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SLM] Allow TensorStructInfo to specify parameter in export [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #16737:
URL: https://github.com/apache/tvm/pull/16737#issuecomment-2010582700
That makes sense, and I agree for the majority of SLM functions. For `nn.Module.export_tvm`, since the purpose is to translate to the Relax function. Since it already depends on the Relax IR for the output of `export_tvm`, there's no additional leakage by having the arguments of `export_tvm` be expressed in Relax IR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SLM] Allow TensorStructInfo to specify parameter in export [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16737:
URL: https://github.com/apache/tvm/pull/16737#issuecomment-2009829433
As of now, the design rationale of SLM was to make this year reasonably self-contained, without having to leak through the layer below.
I understand there are some levels of tradeoff here, but would be good to still center around most of the APIs for `nn.spec.Tensor` for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org