Re: [PR] HDDS-7307. Move S3 Gateway web content to separate port [ozone]

["fapifta (via GitHub)" <gi...@apache.org>]

fapifta commented on code in PR #6898:
URL: https://github.com/apache/ozone/pull/6898#discussion_r1905103129


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/HttpServer2.java:
##########
@@ -446,6 +447,11 @@ private void loadSSLConfiguration() throws IOException {
       excludeCiphers = sslConf.get(SSLFactory.SSL_SERVER_EXCLUDE_CIPHER_LIST);
     }
 
+    public Builder withoutDefaultApps() {

Review Comment:
   I am not opinionated on this, but wouldn't it be easier to read the related code if we use a positive name here similarly to BaseHttpServers's `shouldAddDefaultApps` method, and call this method `withDefaultApps` and the holder variable to `useDefaultApps` instead of `skipDefaultApps` so we don't need to negate the value where we use it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org