You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2011/12/28 16:08:56 UTC
[PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Hi
The camel-test component supports currently both JUnit 3.x and 4.x,
each in separate package.
Supporting both requires us to have a fair amount of duplicated code,
one for 3.x and another for 4.x.
I suggest to @deprecated the JUnit 3.x part of the camel-test component.
Then we can remove support for 3.x in Camel 3.0.
Any thoughts?
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Claus Ibsen <cl...@gmail.com>.
On Wed, Dec 28, 2011 at 4:18 PM, Glen Mazza <gm...@talend.com> wrote:
> Can you just yank it out instead of @deprecate? Test classes are not part
> of guaranteed functionality provided to users.
>
camel-itest is a test kit for Camel end users.
So its public API.
http://camel.apache.org/camel-test.html
The test kit makes it easier to write unit tests with Camel.
That said, we use it of course also a lot in Camel for unit testing
the many Camel components we have.
> Glen
>
>
> On 12/28/2011 10:08 AM, Claus Ibsen wrote:
>>
>> Hi
>>
>> The camel-test component supports currently both JUnit 3.x and 4.x,
>> each in separate package.
>> Supporting both requires us to have a fair amount of duplicated code,
>> one for 3.x and another for 4.x.
>>
>> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
>> Then we can remove support for 3.x in Camel 3.0.
>>
>> Any thoughts?
>>
>>
>
>
> --
> Glen Mazza
> Talend Community Coders
> http://coders.talend.com
> blog: http://www.jroller.com/gmazza
>
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Glen Mazza <gm...@talend.com>.
Can you just yank it out instead of @deprecate? Test classes are not
part of guaranteed functionality provided to users.
Glen
On 12/28/2011 10:08 AM, Claus Ibsen wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
--
Glen Mazza
Talend Community Coders
http://coders.talend.com
blog: http://www.jroller.com/gmazza
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Ticket created
https://issues.apache.org/jira/browse/CAMEL-4840
On Wed, Dec 28, 2011 at 4:08 PM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Johan Edstrom <se...@gmail.com>.
+1, I like that.
On Dec 28, 2011, at 8:08 AM, Claus Ibsen wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by David Karlsen <da...@gmail.com>.
+1
Den 28. des. 2011 18:54 skrev "Christian Schneider" <ch...@die-schneider.net>
følgende:
> +1 for deprecation and removing in 3.0.0
>
> Christian
>
> Am 28.12.2011 16:08, schrieb Claus Ibsen:
>
>> Hi
>>
>> The camel-test component supports currently both JUnit 3.x and 4.x,
>> each in separate package.
>> Supporting both requires us to have a fair amount of duplicated code,
>> one for 3.x and another for 4.x.
>>
>> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
>> Then we can remove support for 3.x in Camel 3.0.
>>
>> Any thoughts?
>>
>>
>>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>
>
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Christian Schneider <ch...@die-schneider.net>.
+1 for deprecation and removing in 3.0.0
Christian
Am 28.12.2011 16:08, schrieb Claus Ibsen:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Christian Müller <ch...@gmail.com>.
+1
On Wed, Dec 28, 2011 at 4:08 PM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
>
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
Regards
JB
On 12/28/2011 04:08 PM, Claus Ibsen wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Hadrian Zbarcea <hz...@gmail.com>.
+1 on both counts.
Hadrian
On 12/29/2011 12:54 AM, Willem Jiang wrote:
>
> Here is my +1.
> BTW, camel-core unit tests are using the JUnit3 classes because we don't
> have the API module to let the camel-test depends on.
> I think we can address it in Camel 3.0.
>
>
> On Thu Dec 29 10:09:29 2011, Daniel Kulp wrote:
>>
>> +1
>>
>> I actually forgot about this. A few months ago, I did go through many
>> of the
>> in-tree test cases that were still using the Junit3 version and
>> changed them
>> to use the Junit4 base class. When I did that, I was going to suggest the
>> same thing, but forgot. :-(
>>
>> Dan
>>
>>
>> On Wednesday, December 28, 2011 4:08:56 PM Claus Ibsen wrote:
>>> Hi
>>>
>>> The camel-test component supports currently both JUnit 3.x and 4.x,
>>> each in separate package.
>>> Supporting both requires us to have a fair amount of duplicated code,
>>> one for 3.x and another for 4.x.
>>>
>>> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
>>> Then we can remove support for 3.x in Camel 3.0.
>>>
>>> Any thoughts?
>
>
>
--
Hadrian Zbarcea
Principal Software Architect
Talend, Inc
http://coders.talend.com/
http://camelbot.blogspot.com/
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Willem Jiang <wi...@gmail.com>.
Here is my +1.
BTW, camel-core unit tests are using the JUnit3 classes because we
don't have the API module to let the camel-test depends on.
I think we can address it in Camel 3.0.
On Thu Dec 29 10:09:29 2011, Daniel Kulp wrote:
>
> +1
>
> I actually forgot about this. A few months ago, I did go through many of the
> in-tree test cases that were still using the Junit3 version and changed them
> to use the Junit4 base class. When I did that, I was going to suggest the
> same thing, but forgot. :-(
>
> Dan
>
>
> On Wednesday, December 28, 2011 4:08:56 PM Claus Ibsen wrote:
>> Hi
>>
>> The camel-test component supports currently both JUnit 3.x and 4.x,
>> each in separate package.
>> Supporting both requires us to have a fair amount of duplicated code,
>> one for 3.x and another for 4.x.
>>
>> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
>> Then we can remove support for 3.x in Camel 3.0.
>>
>> Any thoughts?
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang
Weibo: willemjiang
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Daniel Kulp <dk...@apache.org>.
+1
I actually forgot about this. A few months ago, I did go through many of the
in-tree test cases that were still using the Junit3 version and changed them
to use the Junit4 base class. When I did that, I was going to suggest the
same thing, but forgot. :-(
Dan
On Wednesday, December 28, 2011 4:08:56 PM Claus Ibsen wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
--
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com
Re: [PROPOSAL] - camel-test - @deprecate JUnit 3.x API
Posted by Freeman Fang <fr...@gmail.com>.
+1
Freeman
On 2011-12-28, at 下午11:08, Claus Ibsen wrote:
> Hi
>
> The camel-test component supports currently both JUnit 3.x and 4.x,
> each in separate package.
> Supporting both requires us to have a fair amount of duplicated code,
> one for 3.x and another for 4.x.
>
> I suggest to @deprecated the JUnit 3.x part of the camel-test
> component.
> Then we can remove support for 3.x in Camel 3.0.
>
> Any thoughts?
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus, fusenews
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
---------------------------------------------
Freeman Fang
FuseSource
Email:ffang@fusesource.com
Web: fusesource.com
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com