You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/12/15 02:08:09 UTC

[kudu-CR](gh-pages) site tool: document --no-verify-source flag 

Hello Will Berkeley,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8848

to review the following change.


Change subject: site_tool: document --no-verify-source flag
......................................................................

site_tool: document --no-verify-source flag

Print that this flag exists in the usage text so that I don't have to
read the source code every time I want to do a static render for testing
and code review purposes.

Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/8848/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
......................................................................

site_tool: document --no-verify-source flag

Print that this flag exists in the usage text so that I don't have to
read the source code every time I want to do a static render for testing
and code review purposes.

Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Reviewed-on: http://gerrit.cloudera.org:8080/8848
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Mike Percy: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 23:09:37 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) site tool: document --no-verify-source flag

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8848 )

Change subject: site_tool: document --no-verify-source flag
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23535a0cc92646b17b176bf31154160f040902c
Gerrit-Change-Number: 8848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 18:47:55 +0000
Gerrit-HasComments: No