You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/06/08 23:12:10 UTC

Review Request: The equals method checks type against Pair

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11752/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

The equals method checks type against Pair - may be a copy-paste error


Diffs
-----

  utils/src/com/cloud/utils/Ternary.java fee69ee 
  utils/test/com/cloud/utils/TernaryTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11752/diff/


Testing
-------

Test included


Thanks,

Laszlo Hornyak

Re: Review Request: The equals method checks type against Pair

Posted by Alex Huang <al...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11752/#review21676
-----------------------------------------------------------

Ship it!


Commit ID on master: a1a68ed0c4b722f6f83733d0b110debde2a1041e

- Alex Huang


On June 8, 2013, 9:12 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11752/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 9:12 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> The equals method checks type against Pair - may be a copy-paste error
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/Ternary.java fee69ee 
>   utils/test/com/cloud/utils/TernaryTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11752/diff/
> 
> 
> Testing
> -------
> 
> Test included
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>