You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2009/02/20 03:34:02 UTC

[jira] Created: (BUILDR-257) Release should fail if tag already exists

Release should fail if tag already exists
-----------------------------------------

                 Key: BUILDR-257
                 URL: https://issues.apache.org/jira/browse/BUILDR-257
             Project: Buildr
          Issue Type: Improvement
    Affects Versions: 1.3.3, 1.3.2, 1.3.1, 1.3, 1.2.10
            Reporter: Alexis Midon


Today before creating the tag in the vcs, the release task deletes any existing tag with the same name, and then creates a new one.
Meaning that if people have already checked out the old tag, the content  will changed behind their backs and they might not be aware of it.

It seems really dangerous.

If a tag already exists, the release task should fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-257) Release should fail if tag already exists

Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677187#action_12677187 ] 

Alexis Midon commented on BUILDR-257:
-------------------------------------

The historical reason for deleting the tag seems to be that,  'svn copy'  create a new dir in the existing tag instead of overriding it.

I still think the release should fail (early) if the tag release

> Release should fail if tag already exists
> -----------------------------------------
>
>                 Key: BUILDR-257
>                 URL: https://issues.apache.org/jira/browse/BUILDR-257
>             Project: Buildr
>          Issue Type: Improvement
>    Affects Versions: 1.2.10, 1.3, 1.3.1, 1.3.2, 1.3.3
>            Reporter: Alexis Midon
>
> Today before creating the tag in the vcs, the release task deletes any existing tag with the same name, and then creates a new one.
> Meaning that if people have already checked out the old tag, the content  will changed behind their backs and they might not be aware of it.
> It seems really dangerous.
> If a tag already exists, the release task should fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-257) Release should fail if tag already exists

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme resolved BUILDR-257.
-----------------------------------

    Resolution: Won't Fix

Marked as won't fix/invalid. It's up to the user to do his homework. With git there is more than one canonical repo as well, so this becomes a bit irrelevant.

> Release should fail if tag already exists
> -----------------------------------------
>
>                 Key: BUILDR-257
>                 URL: https://issues.apache.org/jira/browse/BUILDR-257
>             Project: Buildr
>          Issue Type: Improvement
>    Affects Versions: 1.2.10, 1.3, 1.3.1, 1.3.2, 1.3.3
>            Reporter: Alexis Midon
>
> Today before creating the tag in the vcs, the release task deletes any existing tag with the same name, and then creates a new one.
> Meaning that if people have already checked out the old tag, the content  will changed behind their backs and they might not be aware of it.
> It seems really dangerous.
> If a tag already exists, the release task should fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-257) Release should fail if tag already exists

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839375#action_12839375 ] 

Antoine Toulme commented on BUILDR-257:
---------------------------------------

It's fairly bad but the old tag is still stored in history.

Not sure if the same applies for git releases (if you can find older tags in there).

> Release should fail if tag already exists
> -----------------------------------------
>
>                 Key: BUILDR-257
>                 URL: https://issues.apache.org/jira/browse/BUILDR-257
>             Project: Buildr
>          Issue Type: Improvement
>    Affects Versions: 1.2.10, 1.3, 1.3.1, 1.3.2, 1.3.3
>            Reporter: Alexis Midon
>
> Today before creating the tag in the vcs, the release task deletes any existing tag with the same name, and then creates a new one.
> Meaning that if people have already checked out the old tag, the content  will changed behind their backs and they might not be aware of it.
> It seems really dangerous.
> If a tag already exists, the release task should fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.