[GitHub] [cassandra] cowtowncoder commented on a change in pull request #1137: [WIP] CASSANDRA-16851: upgrade Jackson 2.9->2.12

[GitBox <gi...@apache.org>]

cowtowncoder commented on a change in pull request #1137:
URL: https://github.com/apache/cassandra/pull/1137#discussion_r698660863



##########
File path: src/java/org/apache/cassandra/cql3/Json.java
##########
@@ -42,7 +42,7 @@
      */
     public static String quoteAsJsonString(String s)
     {
-        return new String(BufferRecyclers.getJsonStringEncoder().quoteAsString(s));
+        return new String(JsonStringEncoder.getInstance().quoteAsString(s));

Review comment:
       With 2.12.5 I can revert this change as I added back the method in question for backwards-compatibility.
   Ideally (in future) call will be changed, but it is lower risk doing minimal change.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org