You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/25 11:23:15 UTC
[GitHub] [inlong] EMsnap opened a new pull request, #6284: [INLONG-6283] sort jar conflict between sort-dist and connector
EMsnap opened a new pull request, #6284:
URL: https://github.com/apache/inlong/pull/6284
- Fixes #6283
### Motivation
sort jar conflict between sort-dist and connector
### Modifications
make debezium-core in sort-format-json provided since the dependency can be found in connector jar
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6284: [INLONG-6283][Sort] Fix the JAR conflict between sort-dist and sort-connector
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6284:
URL: https://github.com/apache/inlong/pull/6284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #6284: [INLONG-6283][Sort] Fix Jar Conflict Between Sort-dist And Connector
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #6284:
URL: https://github.com/apache/inlong/pull/6284#discussion_r1004437164
##########
inlong-sort/sort-formats/format-json/pom.xml:
##########
@@ -78,6 +78,7 @@
<dependency>
<groupId>io.debezium</groupId>
<artifactId>debezium-core</artifactId>
+ <scope>provided</scope>
Review Comment:
suggested remove it if not format-json necessary if it is just for mysql cdc, put `DebeziumJson` in mysql-cdc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #6284: [INLONG-6283][Sort] Fix the JAR conflict between sort-dist and sort-connector
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #6284:
URL: https://github.com/apache/inlong/pull/6284#discussion_r1005143105
##########
inlong-sort/sort-formats/format-json/pom.xml:
##########
@@ -78,6 +78,7 @@
<dependency>
<groupId>io.debezium</groupId>
<artifactId>debezium-core</artifactId>
+ <scope>provided</scope>
Review Comment:
it maybe useful for future sink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #6284: [INLONG-6283][Sort] Fix Jar Conflict Between Sort-dist And Connector
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #6284:
URL: https://github.com/apache/inlong/pull/6284#discussion_r1004437164
##########
inlong-sort/sort-formats/format-json/pom.xml:
##########
@@ -78,6 +78,7 @@
<dependency>
<groupId>io.debezium</groupId>
<artifactId>debezium-core</artifactId>
+ <scope>provided</scope>
Review Comment:
suggested remove it if not format-json necessary if it is just for mysql cdc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org