You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Max Ullinger (JIRA)" <ji...@apache.org> on 2010/07/26 10:37:51 UTC
[jira] Created: (CAMEL-2993) Enable the deletion of routes via REST
in camel-web
Enable the deletion of routes via REST in camel-web
---------------------------------------------------
Key: CAMEL-2993
URL: https://issues.apache.org/activemq/browse/CAMEL-2993
Project: Apache Camel
Issue Type: Improvement
Components: camel-web
Affects Versions: 2.4.0, 2.3.0, 2.2.0, 2.1.0
Environment: Any
Reporter: Max Ullinger
The camel-web allows a user to deploy and manipulate routes.
It seems currently impossible to delete routes through camel-web.
A delete operation on the route to be deleted would complete the REST interface:
http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
e.g.:
RouteResource.java
@Delete
public void removeRoute() {
getCamelContext().removeRouteDefinition(this.name);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2993) Enable the deletion of routes via REST
in camel-web
Posted by "Ben O'Day (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben O'Day updated CAMEL-2993:
-----------------------------
Attachment: camel-web-route-remove.txt
This patch adds the following:
-REST support for removing a route via URI /route/<routeid>/remove
-a new column to the route list page with a link to remove a given route
-a basic unit test of this API
Let me know if you have any feedback on this approach.
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2993) Enable the deletion of routes via
REST in camel-web
Posted by "Ben O'Day (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61298#action_61298 ]
Ben O'Day commented on CAMEL-2993:
----------------------------------
Clause, just an FYI...I submitted that patch. I assume it was reviewed prior to committing, but since it was my first patch, I wanted to make sure...thx
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2993) Enable the deletion of routes via
REST in camel-web
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-2993:
----------------------------------
Assignee: Claus Ibsen
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2993) Enable the deletion of routes via
REST in camel-web
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61317#action_61317 ]
Claus Ibsen commented on CAMEL-2993:
------------------------------------
Ben thanks for the 2nd patch. I have committed it to trunk: 987891.
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-hide-remove-until-stopped.txt, camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2993) Enable the deletion of
routes via REST in camel-web
Posted by "Ben O'Day (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61298#action_61298 ]
Ben O'Day edited comment on CAMEL-2993 at 8/19/10 4:47 PM:
-----------------------------------------------------------
Claus, just an FYI...I submitted that patch. I assume it was reviewed prior to committing, but since it was my first patch, I wanted to make sure...thx
was (Author: boday):
Clause, just an FYI...I submitted that patch. I assume it was reviewed prior to committing, but since it was my first patch, I wanted to make sure...thx
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2993) Enable the deletion of routes via
REST in camel-web
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61311#action_61311 ]
Claus Ibsen commented on CAMEL-2993:
------------------------------------
Ah thanks Ben for the patch.
I have though, maybe the remove button should only be visible when the route has been stopped first.
This ensures its a 2 way step to remove a route. 1 = stop, 2 = remove.
This is the same way you have to do it from JMX.
For example to avoid troubles if you accidentally press the wrong button on a running route.
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2993) Enable the deletion of routes via
REST in camel-web
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2993.
--------------------------------
Fix Version/s: 2.5.0
Resolution: Fixed
trunk: 987250.
Thanks Max for the patch.
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Fix For: 2.5.0
>
> Attachments: camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2993) Enable the deletion of routes via REST
in camel-web
Posted by "Ben O'Day (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben O'Day updated CAMEL-2993:
-----------------------------
Attachment: camel-web-route-hide-remove-until-stopped.txt
sure, new patch is attached to only show the 'remove' link when the route "is.Startable"...thanks Claus
> Enable the deletion of routes via REST in camel-web
> ---------------------------------------------------
>
> Key: CAMEL-2993
> URL: https://issues.apache.org/activemq/browse/CAMEL-2993
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-web
> Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.4.0
> Environment: Any
> Reporter: Max Ullinger
> Assignee: Claus Ibsen
> Fix For: 2.5.0
>
> Attachments: camel-web-route-hide-remove-until-stopped.txt, camel-web-route-remove.txt
>
>
> The camel-web allows a user to deploy and manipulate routes.
> It seems currently impossible to delete routes through camel-web.
> A delete operation on the route to be deleted would complete the REST interface:
> http://en.wikipedia.org/wiki/Representational_State_Transfer#RESTful_web_services
> e.g.:
> RouteResource.java
> @Delete
> public void removeRoute() {
> getCamelContext().removeRouteDefinition(this.name);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.