You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/09 22:07:21 UTC
Review Request 28869: Added a hash function for Node.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28869/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Needed this to store Node keys in hashmap.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be
Diff: https://reviews.apache.org/r/28869/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28869: Added a hash function for Node.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 9, 2014, 9:08 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/node.hpp, line 7
> > <https://reviews.apache.org/r/28869/diff/1/?file=787250#file787250line7>
> >
> > why did this move? alphabetically it comes before those above.
It is inside a folder, from looking around the code we follow this style pretty consistently (folders are separated and come after top level files).
> On Dec. 9, 2014, 9:08 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/node.hpp, line 13
> > <https://reviews.apache.org/r/28869/diff/1/?file=787250#file787250line13>
> >
> > this should be above glog, right?
C-like includes first, whoops I'll move glog above sstream.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28869/#review64437
-----------------------------------------------------------
On Dec. 9, 2014, 9:07 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28869/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 9:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this to store Node keys in hashmap.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be
>
> Diff: https://reviews.apache.org/r/28869/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28869: Added a hash function for Node.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28869/#review64437
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28869/#comment107146>
why did this move? alphabetically it comes before those above.
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28869/#comment107147>
this should be above glog, right?
- Dominic Hamon
On Dec. 9, 2014, 1:07 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28869/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 1:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this to store Node keys in hashmap.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be
>
> Diff: https://reviews.apache.org/r/28869/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28869: Added a hash function for Node.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28869/
-----------------------------------------------------------
(Updated Dec. 9, 2014, 10 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fixed an include ordering issue and adding some whitespace to this file.
Repository: mesos-git
Description
-------
Needed this to store Node keys in hashmap.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be
Diff: https://reviews.apache.org/r/28869/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28869: Added a hash function for Node.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28869/#review64443
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28869/#comment107158>
Add an extra blank linke here.
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28869/#comment107159>
Add an extra blank line here.
- Jie Yu
On Dec. 9, 2014, 9:07 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28869/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 9:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed this to store Node keys in hashmap.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp eb48c54cc1531d9f55213a58dd9496e969d5d7be
>
> Diff: https://reviews.apache.org/r/28869/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>