You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2014/02/10 19:03:39 UTC
Review Request 17911: Extract common hdfs directories creation code per
services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Repository: ambari
Description
-------
Directory creation was moved from namenode start to each service.
Diffs
-----
ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py fddd1b7
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py 95f3e30
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad
ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
Diff: https://reviews.apache.org/r/17911/diff/
Testing
-------
Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
Thanks,
Eugene Chekanskiy
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/#review34182
-----------------------------------------------------------
ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py
<https://reviews.apache.org/r/17911/#comment64197>
typo
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py
<https://reviews.apache.org/r/17911/#comment64196>
Please put action, as a first kwarg of params.HdfsDirectory, this is just a part of style
- Andrew Onischuk
On Feb. 10, 2014, 6:03 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17911/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 6:03 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4583
> https://issues.apache.org/jira/browse/AMBARI-4583
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Directory creation was moved from namenode start to each service.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
> ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
> ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
> ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py fddd1b7
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py 95f3e30
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad
> ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
> ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
> ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
>
> Diff: https://reviews.apache.org/r/17911/diff/
>
>
> Testing
> -------
>
> Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Feb. 10, 2014, 7:12 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py, line 112
> > <https://reviews.apache.org/r/17911/diff/1/?file=481907#file481907line112>
> >
> > We should not hide redefined resource under the same name, as it will be hard for newcomers to understand how it works
Dmitritro, this does not hide it.
params.HdfsDirectory
and
HdfsDirectory
would still be different things.
But, when we have a lot of partial resources, that actually would benefit a lot (the same names mapping with and without params). I think renaming that would actually be more confusing.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/#review34093
-----------------------------------------------------------
On Feb. 10, 2014, 6:03 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17911/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 6:03 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4583
> https://issues.apache.org/jira/browse/AMBARI-4583
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Directory creation was moved from namenode start to each service.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
> ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
> ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
> ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py fddd1b7
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py 95f3e30
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad
> ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
> ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
> ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
>
> Diff: https://reviews.apache.org/r/17911/diff/
>
>
> Testing
> -------
>
> Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/#review34093
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py
<https://reviews.apache.org/r/17911/#comment64062>
using reserved words ("type") as variable names is usually considered a bad practice
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py
<https://reviews.apache.org/r/17911/#comment64061>
We should not hide redefined resource under the same name, as it will be hard for newcomers to understand how it works
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py
<https://reviews.apache.org/r/17911/#comment64063>
let's remove commented out staff
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
<https://reviews.apache.org/r/17911/#comment64064>
probably commented out staff may be removed
- Dmitro Lisnichenko
On Feb. 10, 2014, 6:03 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17911/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 6:03 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4583
> https://issues.apache.org/jira/browse/AMBARI-4583
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Directory creation was moved from namenode start to each service.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
> ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
> ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
> ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py fddd1b7
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py 95f3e30
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad
> ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
> ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
> ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
>
> Diff: https://reviews.apache.org/r/17911/diff/
>
>
> Testing
> -------
>
> Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/#review34189
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 11, 2014, 4:02 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17911/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 4:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4583
> https://issues.apache.org/jira/browse/AMBARI-4583
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Directory creation was moved from namenode start to each service.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
> ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
> ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
> ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py e77a233
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 8e85637
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py bea67ab
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 324e307
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py d9a4709
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d68d212
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py c0f48dc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py f94a04f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 8a08a7e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 8a9b3e9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 3d5bb35
> ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
> ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
> ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
>
> Diff: https://reviews.apache.org/r/17911/diff/
>
>
> Testing
> -------
>
> Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/#review34190
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 11, 2014, 4:02 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17911/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 4:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4583
> https://issues.apache.org/jira/browse/AMBARI-4583
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Directory creation was moved from namenode start to each service.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
> ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
> ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
> ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py e77a233
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 8e85637
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py bea67ab
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 324e307
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py d9a4709
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d68d212
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py c0f48dc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py f94a04f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 8a08a7e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 8a9b3e9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
> ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 3d5bb35
> ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
> ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
> ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
>
> Diff: https://reviews.apache.org/r/17911/diff/
>
>
> Testing
> -------
>
> Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 4:02 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Changes
-------
patch changed.
Bugs: AMBARI-4583
https://issues.apache.org/jira/browse/AMBARI-4583
Repository: ambari
Description
-------
Directory creation was moved from namenode start to each service.
Diffs (updated)
-----
ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py e77a233
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 8e85637
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py bea67ab
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 324e307
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py d9a4709
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d68d212
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py c0f48dc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_client.py 0f2a1bc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py f94a04f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 8a08a7e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 8a9b3e9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 3d5bb35
ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
Diff: https://reviews.apache.org/r/17911/diff/
Testing
-------
Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
Thanks,
Eugene Chekanskiy
Re: Review Request 17911: Extract common hdfs directories creation code per
services
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17911/
-----------------------------------------------------------
(Updated Feb. 10, 2014, 6:03 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: AMBARI-4583
https://issues.apache.org/jira/browse/AMBARI-4583
Repository: ambari
Description
-------
Directory creation was moved from namenode start to each service.
Diffs
-----
ambari-agent/src/main/python/resource_management/libraries/providers/__init__.py 59b6bb5
ambari-agent/src/main/python/resource_management/libraries/providers/hdfs_directory.py PRE-CREATION
ambari-agent/src/main/python/resource_management/libraries/resources/__init__.py 7c86d18
ambari-agent/src/main/python/resource_management/libraries/resources/hdfs_directory.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase.py fddd1b7
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 5f03871
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ca8393c
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/historyserver.py 972a767
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/mapreduce.py c5fd002
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie.py e1a7869
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/oozie_server.py eca2a56
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/package/scripts/params.py cd3e7bb
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/params.py 83211e1
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/package/scripts/webhcat.py ae12f54
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase.py 95f3e30
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_master.py 9c78e5c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_regionserver.py 2d91e75
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py 44e6a77
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py 3ad81a1
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 4c2a335
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py 53f7693
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py 9e45f9d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/params.py 08a01a4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/package/scripts/webhcat.py c56f1c5
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/historyserver.py 3b6f8cc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/nodemanager.py dbeaca0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py 986356e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 4df7f4e
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 7f27862
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py c3789a2
ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_regionserver.py 35a6403
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 43a8cdf
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_historyserver.py df58f13
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad
ambari-server/src/test/python/stacks/1.3.2/OOZIE/test_oozie_server.py ccc027c
ambari-server/src/test/python/stacks/1.3.2/WEBHCAT/test_webhcat_server.py 7b032c9
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py c8e61d6
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 231ae94
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 3971000
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 300f9c8
ambari-server/src/test/python/stacks/2.0.6/WEBHCAT/test_webhcat_server.py 83ca8f2
ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py a966bea
ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py a017770
ambari-server/src/test/python/stacks/utils/RMFTestCase.py d0580ab
Diff: https://reviews.apache.org/r/17911/diff/
Testing
-------
Tested on 1.x.x 2.x.x in secured and default configurations. Unit tests fixed appropriate to changes.
Thanks,
Eugene Chekanskiy