You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/12 16:54:08 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

tillrohrmann opened a new pull request #18343:
URL: https://github.com/apache/flink/pull/18343


   This commit sets the locale to en-US in order to avoid ambiguous decimal formattings that
   can cause the CPUResourceTest to fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011257264


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 95cf3f884093ae61734d4bc0ed1d8214d821eb62 (Wed Jan 12 16:58:39 UTC 2022)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94936f35c707fa2d869fb92800610ee35b0a4f4f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556) 
   * 1b410df18c538ddd755adaca39e9033fa8a208cf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29630",
       "triggerID" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b410df18c538ddd755adaca39e9033fa8a208cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29630) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 95cf3f884093ae61734d4bc0ed1d8214d821eb62 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1014408012


   Thanks for the review @zentol. I've added the missing lines and force pushed an update. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29630",
       "triggerID" : "1b410df18c538ddd755adaca39e9033fa8a208cf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94936f35c707fa2d869fb92800610ee35b0a4f4f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556) 
   * 1b410df18c538ddd755adaca39e9033fa8a208cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29630) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 95cf3f884093ae61734d4bc0ed1d8214d821eb62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345) 
   * 94936f35c707fa2d869fb92800610ee35b0a4f4f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 94936f35c707fa2d869fb92800610ee35b0a4f4f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1015207875


   Actually, I will first re-run the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556",
       "triggerID" : "94936f35c707fa2d869fb92800610ee35b0a4f4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 95cf3f884093ae61734d4bc0ed1d8214d821eb62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345) 
   * 94936f35c707fa2d869fb92800610ee35b0a4f4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29556) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #18343:
URL: https://github.com/apache/flink/pull/18343


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 95cf3f884093ae61734d4bc0ed1d8214d821eb62 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1011258099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345",
       "triggerID" : "95cf3f884093ae61734d4bc0ed1d8214d821eb62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 95cf3f884093ae61734d4bc0ed1d8214d821eb62 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #18343: [FLINK-25633] Set locale to en-US to avoid ambiguous decimal formattings

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18343:
URL: https://github.com/apache/flink/pull/18343#issuecomment-1015207464


   Thanks for the review @zentol. Merging this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org