You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by gresockj <gi...@git.apache.org> on 2015/12/24 15:19:49 UTC
[GitHub] nifi pull request: NIFI-1291: Moving BinFiles to nifi-processor-ut...
GitHub user gresockj opened a pull request:
https://github.com/apache/nifi/pull/149
NIFI-1291: Moving BinFiles to nifi-processor-utilities
I used Bryan Bende's suggestion and moved this processor parent to nifi-processor-utilities.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gresockj/nifi NIFI-1291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 6877cf03d94146e42bdcfa0d61c38cf9c0f46d3c
Author: gresockj <jg...@gmail.com>
Date: 2015-12-24T14:18:11Z
NIFI-1291: Moving BinFiles to nifi-processor-utilities
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1291: Moving BinFiles to nifi-processor-ut...
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/149#issuecomment-167262594
@gresockj thanks for the pr! I started digging in, and I think the discussion on where this goes (which I added to the ticket) probably should have gone on a little longer (no fault of yours, I'm glad you took the initiative and put the code together). I could be wrong, but I think @bbende was more discussing in abstract terms. I have to admit, the abstract processor feels a little bit out of place in nifi-processor-utils, but I don't have a good answer for where general purpose abstract processors should be! I think @joewitt may have been suggesting a new module like nifi-commons/nifi-abstract-processors/<abstract processor>?
Secondly, I think rather than a move, deprecating the one in :nifi-standard-processors and making a copy of the classes to the new location would be appropriate for 0.5.0. I'm pretty sure this would constitute a breaking change as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1291: Moving BinFiles to nifi-processor-ut...
Posted by gresockj <gi...@git.apache.org>.
Github user gresockj closed the pull request at:
https://github.com/apache/nifi/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1291: Moving BinFiles to nifi-processor-ut...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/149#issuecomment-168542556
@gresockj it appears that the code is removed then added and at least for me it is making review a bit tricky. I think the expected approach (correct me if wrong) is there would simply be new classes created in the utility module and then the existing classes in standard procs would be marked deprecated and the existing processor impl would use the utility module import instead (thus making the now deprecated classes just sit there unused until they are removed in 1.0.0). Does this make sense?
Thanks
JOe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---