You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/02 20:44:54 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5457: build(deps): update sqlparser requirement from 0.30 to 0.31 w/ fixes
alamb opened a new pull request, #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/pull/5451
# Rationale for this change
New version of sqlparser was released and we need a few changes to DataFusion to acknowledge we don't support newly added syntax
# What changes are included in this PR?
Changes from @dependabot in https://github.com/apache/arrow-datafusion/pull/5451 and updates to make ti compile
# Are these changes tested?
Existing tests cover it
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.32 w/ API update
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1460356509
@andygrove if you have time to review this upgrade PR I would like to get it in prior to the release on Friday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.31 w/ fixes
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1456193592
Specifically
```
#[test]
fn table_with_column_alias() {
let sql = "SELECT a, b, c
FROM lineitem l (a, b, c)";
let expected = "Projection: a, b, c\
\n Projection: l.l_item_id AS a, l.l_description AS b, l.price AS c\
\n SubqueryAlias: l\
\n TableScan: lineitem";
quick_test(sql, expected);
}
```
Fails with:
```
---- table_with_column_alias stdout ----
thread 'table_with_column_alias' panicked at 'called `Result::unwrap()` on an `Err` value: SQL(ParserError("Expected identifier, found: ,"))', datafusion/sql/tests/integration_test.rs:2412:34
stack backtrace:
0: rust_begin_unwind
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/panicking.rs:575:5
1: core::panicking::panic_fmt
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:64:14
2: core::result::unwrap_failed
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/result.rs:1791:5
3: core::result::Result<T,E>::unwrap
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/result.rs:1113:23
4: integration_test::quick_test
at ./tests/integration_test.rs:2412:16
5: integration_test::table_with_column_alias
at ./tests/integration_test.rs:499:5
6: integration_test::table_with_column_alias::{{closure}}
at ./tests/integration_test.rs:491:30
7: core::ops::function::FnOnce::call_once
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/ops/function.rs:507:5
8: core::ops::function::FnOnce::call_once
at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/ops/function.rs:507:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.31 w/ fixes
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1453420656
@ursabot benchmark help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.31 w/ fixes
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1456253779
Upstream issue: https://github.com/sqlparser-rs/sqlparser-rs/issues/826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.31 w/ fixes
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1454177367
🤔 looks like some real problem in sql-parser upgrade -- I will investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.32 w/ API update
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1460819430
Thank you @appletreeisyellow and @tustvold !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.32 w/ API update
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457#issuecomment-1460840362
Benchmark runs are scheduled for baseline = 8a1b1339052b57ac01d730a57e2f3bb321b103ba and contender = 84530a2f5488d187d7629dc59bf443c46a028f19. 84530a2f5488d187d7629dc59bf443c46a028f19 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d625af0213cc4147b67520bcd9470ed5...261a2adca4e04e078734d8d0569e80a4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/318bede8a38042408eff340989c2e76e...605f513215ce40efaab326af1d503990/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fdbbeac14dd5430fbe74dce1e9d3ef00...a4639ecd3a9c4060b2754dcc35f8dfaf/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7eebae0a83c541b69eadd243c426f1f9...8da90c2deac749c1896ce5acd1654701/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5457: build(deps): update sqlparser requirement from 0.30 to 0.32 w/ API update
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5457:
URL: https://github.com/apache/arrow-datafusion/pull/5457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org