You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by mb...@apache.org on 2016/05/08 21:13:06 UTC

[2/3] incubator-systemml git commit: [SYSTEMML-655][SYSTEMML-651] Fix warnings (missing imports, res leaks)

[SYSTEMML-655][SYSTEMML-651] Fix warnings (missing imports, res leaks)

Project: http://git-wip-us.apache.org/repos/asf/incubator-systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-systemml/commit/a7c36891
Tree: http://git-wip-us.apache.org/repos/asf/incubator-systemml/tree/a7c36891
Diff: http://git-wip-us.apache.org/repos/asf/incubator-systemml/diff/a7c36891

Branch: refs/heads/master
Commit: a7c36891ee9bd0634bde485b72b0cce90dc1c24d
Parents: 2f1d6fa
Author: Matthias Boehm <mb...@us.ibm.com>
Authored: Sat May 7 20:43:27 2016 -0700
Committer: Matthias Boehm <mb...@us.ibm.com>
Committed: Sat May 7 20:44:16 2016 -0700

----------------------------------------------------------------------
 src/main/java/org/apache/sysml/yarn/DMLYarnClient.java           | 1 -
 .../test/integration/functions/jmlc/JMLCInputOutputTest.java     | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/a7c36891/src/main/java/org/apache/sysml/yarn/DMLYarnClient.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/yarn/DMLYarnClient.java b/src/main/java/org/apache/sysml/yarn/DMLYarnClient.java
index ec5e4b0..37d42e6 100644
--- a/src/main/java/org/apache/sysml/yarn/DMLYarnClient.java
+++ b/src/main/java/org/apache/sysml/yarn/DMLYarnClient.java
@@ -27,7 +27,6 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.apache.commons.lang.StringUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.fs.FSDataInputStream;

http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/a7c36891/src/test/java/org/apache/sysml/test/integration/functions/jmlc/JMLCInputOutputTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/sysml/test/integration/functions/jmlc/JMLCInputOutputTest.java b/src/test/java/org/apache/sysml/test/integration/functions/jmlc/JMLCInputOutputTest.java
index eee48b2..44188eb 100644
--- a/src/test/java/org/apache/sysml/test/integration/functions/jmlc/JMLCInputOutputTest.java
+++ b/src/test/java/org/apache/sysml/test/integration/functions/jmlc/JMLCInputOutputTest.java
@@ -55,6 +55,7 @@ public class JMLCInputOutputTest extends AutomatedTestBase {
 
 		setExpectedStdOut("total:5");
 		script.executeScript();
+		conn.close();
 	}
 
 	@Test
@@ -70,6 +71,7 @@ public class JMLCInputOutputTest extends AutomatedTestBase {
 
 		setExpectedStdOut("total:8.0");
 		script.executeScript();
+		conn.close();
 	}
 
 	// See: https://issues.apache.org/jira/browse/SYSTEMML-656
@@ -103,6 +105,7 @@ public class JMLCInputOutputTest extends AutomatedTestBase {
 
 		setExpectedStdOut("total:9");
 		script.executeScript();
+		conn.close();
 	}
 
 	// See: https://issues.apache.org/jira/browse/SYSTEMML-658
@@ -136,6 +139,7 @@ public class JMLCInputOutputTest extends AutomatedTestBase {
 
 		setExpectedStdOut("result:hellogoodbye");
 		script.executeScript();
+		conn.close();
 	}
 
 }
\ No newline at end of file