[GitHub] [airflow] potiuk commented on issue #8872: Add dependencies on build image

[GitBox <gi...@apache.org>]

potiuk commented on issue #8872:
URL: https://github.com/apache/airflow/issues/8872#issuecomment-713729571


   ONBUILD does not solve your problems. I wonder how do you imagine it solve the problem? We have no GCC/build-essentials in the  image anyway so at the very best you can get exactly the same as with extending the image (unless you have a better idea).  So all the DEV actions are not possible. And everything that you can do with ONBUILD can be done via extending the current image.
   
   ONBUILD is a very controversial idea and it does not serve any other purpose that extension of the Docker image would do.
   
   I.e. @landier  how any ONBUILD is different from:
   
   ```
   FROM apache/airflow:image
   
   USER root
   
   # do whatever you'd like to do in ONBUILD
   
   USER airflow 
   ```
   ?
   
   I actually think about something entirely different. You do not want to use one file. If you look closer, there are some other files used by the docker (scripts mainly). What I thought might be a better way, is to set up automated copying (using copybara or a dedicated Github Actions worfklow)  only what is needed in order to build the image into a separate repository where only those scripts + Dockerfile would be and nothing more. 
   
   This can happen automatically at every commit and then you'd have to only clone the other repository to build your custom image.
   
   WDYT? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org