You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "nmalin (via GitHub)" <gi...@apache.org> on 2026/06/09 09:34:33 UTC
[PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
nmalin opened a new pull request, #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342
The screenlet can receive a title to describe it content on the body, and you can collapse it to optimize the page.
If you want to display some complex case the title isn't enough so we improve it by added a header screen.
Like this you can prepare your screenlet like :
<screen ...>...
<screenlet screen-header-name="MyScreenletResume" collapsible="true">
<include-grid name="ComplexeGrid" location=".../>
</screenlet>
</screen>
<screen name="MyScreenletResume">
<column-container>
<column>
<label>My Title</label>
<label>My Desc</label>
</column>
<column>
<label>${numberElement}</label>
<label>${warnElement}</label>
</column>
</column-container>...
</screen>
With this, you can use all powerful of screen without add big complexity on the framework to manage complex case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3402101219
##########
framework/webtools/widget/MiscScreens.xml:
##########
@@ -201,6 +201,10 @@ under the License.
<include-form name="LayoutDemoList" location="component://webtools/widget/MiscForms.xml"/>
<include-form name="LayoutDemoForm" location="component://webtools/widget/MiscForms.xml"/>
</screenlet>
+ <screenlet id="screenlet-demo-header" collapsible="true"
+ screen-header-name="WebtoolsLayoutDemoSimpleGridResume">
Review Comment:
Right @jacopoc bad friend resume is a by friend, my fault, I'll fix that !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin merged PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3407776563
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>The screen name to use if you when a complex screenlet header</xs:documentation>
Review Comment:
I updated xsd's sentence, let me know if it's more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3402113598
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>The screen name to use if you when a complex screenlet header</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-location">
+ <xs:annotation>
+ <xs:documentation>The screen location to use if you when a complex screenlet header, if empty use the same location of the screenlet's parent screen</xs:documentation>
Review Comment:
Thanks for take time to review this. I'll reword my sentence !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3401826371
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>The screen name to use if you when a complex screenlet header</xs:documentation>
Review Comment:
The sentence above seems incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3407775947
##########
framework/webtools/widget/MiscScreens.xml:
##########
@@ -201,6 +201,10 @@ under the License.
<include-form name="LayoutDemoList" location="component://webtools/widget/MiscForms.xml"/>
<include-form name="LayoutDemoForm" location="component://webtools/widget/MiscForms.xml"/>
</screenlet>
+ <screenlet id="screenlet-demo-header" collapsible="true"
+ screen-header-name="WebtoolsLayoutDemoSimpleGridResume">
Review Comment:
I replaced "summarize" with "header" because this approach makes it easier to create complex headers for screenlets, which remain visible even when the screenlet is minimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3442439577
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>Name of the screen to be used for the complex display of a screenlet’s header. When the screenlet is minimized, the header remains visible.</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-location">
+ <xs:annotation>
+ <xs:documentation>Location of the screen to be used for the detailed view of a screenlet’s header. If empty use the same location of the screenlet's parent screen</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
</xs:complexType>
Review Comment:
Thanks for suggestion @jacopoc, I applied it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3401821227
##########
framework/webtools/widget/MiscScreens.xml:
##########
@@ -201,6 +201,10 @@ under the License.
<include-form name="LayoutDemoList" location="component://webtools/widget/MiscForms.xml"/>
<include-form name="LayoutDemoForm" location="component://webtools/widget/MiscForms.xml"/>
</screenlet>
+ <screenlet id="screenlet-demo-header" collapsible="true"
+ screen-header-name="WebtoolsLayoutDemoSimpleGridResume">
Review Comment:
The term "Resume" here is confusing. If it is intended to refer to the French term *résumé*, then *Summary* might be a more appropriate translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3401827051
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>The screen name to use if you when a complex screenlet header</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-location">
+ <xs:annotation>
+ <xs:documentation>The screen location to use if you when a complex screenlet header, if empty use the same location of the screenlet's parent screen</xs:documentation>
Review Comment:
The sentence above seems incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3402101219
##########
framework/webtools/widget/MiscScreens.xml:
##########
@@ -201,6 +201,10 @@ under the License.
<include-form name="LayoutDemoList" location="component://webtools/widget/MiscForms.xml"/>
<include-form name="LayoutDemoForm" location="component://webtools/widget/MiscForms.xml"/>
</screenlet>
+ <screenlet id="screenlet-demo-header" collapsible="true"
+ screen-header-name="WebtoolsLayoutDemoSimpleGridResume">
Review Comment:
Right @jacopoc, resume is a bad friend, my fault, I'll fix that !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implemented: Add header screen for the screenlet [ofbiz-framework]
Posted by "jacopoc (via GitHub)" <gi...@apache.org>.
jacopoc commented on code in PR #1342:
URL: https://github.com/apache/ofbiz-framework/pull/1342#discussion_r3411984967
##########
framework/widget/dtd/widget-screen.xsd:
##########
@@ -312,6 +312,16 @@ under the License.
<xs:documentation>Name of the screenlet include-menu sub element that will be used for the screenlet tab bar.</xs:documentation>
</xs:annotation>
</xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-name">
+ <xs:annotation>
+ <xs:documentation>Name of the screen to be used for the complex display of a screenlet’s header. When the screenlet is minimized, the header remains visible.</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
+ <xs:attribute type="xs:string" name="screen-header-location">
+ <xs:annotation>
+ <xs:documentation>Location of the screen to be used for the detailed view of a screenlet’s header. If empty use the same location of the screenlet's parent screen</xs:documentation>
+ </xs:annotation>
+ </xs:attribute>
</xs:complexType>
Review Comment:
For consistency, I'd suggest to use the same definition in both the screen-header-name and screen-header-location attributes, such as:
> Name of the screen to define advanced layouts for a screenlet’s header. When the screenlet is minimized, the header remains visible.
> Location of the screen to define advanced layouts for a screenlet’s header. If empty use the same location of the screenlet's parent screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org