You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Carlos Santana <cs...@gmail.com> on 2013/10/22 23:57:02 UTC

code review for "cordova emulate ios" fix

Can someone take a look.
If it looks good I would like to merged it in

It kind a pain in the but that "cordova emulate ios" was working on 3.0,
and now broken on 3.1
I would like to be fixed on 3.2

https://reviews.apache.org/r/14822/
or
https://github.com/apache/cordova-cli/pull/57

-- 
Carlos Santana
<cs...@gmail.com>

Re: code review for "cordova emulate ios" fix

Posted by Steven Gill <st...@gmail.com>.

Everything looked good to me. I would say pull it in.


On Tue, Oct 22, 2013 at 3:05 PM, Steven Gill <st...@gmail.com> wrote:

> I will review shortly!
>
>
> On Tue, Oct 22, 2013 at 2:57 PM, Carlos Santana <cs...@gmail.com>wrote:
>
>> Can someone take a look.
>> If it looks good I would like to merged it in
>>
>> It kind a pain in the but that "cordova emulate ios" was working on 3.0,
>> and now broken on 3.1
>> I would like to be fixed on 3.2
>>
>> https://reviews.apache.org/r/14822/
>> or
>> https://github.com/apache/cordova-cli/pull/57
>>
>> --
>> Carlos Santana
>> <cs...@gmail.com>
>>
>
>

Re: code review for "cordova emulate ios" fix

Posted by Steven Gill <st...@gmail.com>.

I will review shortly!


On Tue, Oct 22, 2013 at 2:57 PM, Carlos Santana <cs...@gmail.com>wrote:

> Can someone take a look.
> If it looks good I would like to merged it in
>
> It kind a pain in the but that "cordova emulate ios" was working on 3.0,
> and now broken on 3.1
> I would like to be fixed on 3.2
>
> https://reviews.apache.org/r/14822/
> or
> https://github.com/apache/cordova-cli/pull/57
>
> --
> Carlos Santana
> <cs...@gmail.com>
>