You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:04:51 UTC

[GitHub] [iceberg] Fokko commented on pull request #6083: Spark: Remove redundant check for max_concurrent_deletes in spark actions

Fokko commented on PR #6083:
URL: https://github.com/apache/iceberg/pull/6083#issuecomment-1298184931

   Should we also clean up the `checkArgument`:
   ```
   Preconditions.checkArgument(
           maxConcurrentDeletes == null || maxConcurrentDeletes > 0,
           "max_concurrent_deletes should have value > 0, value: %s", maxConcurrentDeletes);
   ```
   Remove the redundant space before `value`, and avoid the string concatenation by passing the `maxConcurrentDeletes` as an argument. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org