[jira] [Updated] (SOLR-7325) Change Slice state into enum

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated SOLR-7325:
-----------------------------
    Attachment: SOLR-7325.patch

Patch implements a basic change, in order to get some feedback first:

* Slice.State declares 4 values: ACTIVE, INACTIVE, CONSTRUCTION, RECOVERY. Are these all the states or did I miss some?

* I documented these very briefly, mostly from what I understood from the code, and some chats I had w/ [~anshumg]. I would definitely appreciate a review on this!

* Slice.state is held internally as an enum, but still exposed as a String:
** Backwards-compatibility wise, is it OK if we change Slice.getState() to return the enum? It's an API-break, but I assume it's pretty expert and the migration is really easy.
** Note that it's still written/read as a String.

* I didn't yet get rid of the state constants:
** Is it OK to just remove them, or should I deprecate them like I did for STATE?

In this issue I would like to handle Slice, and change Replica separately. After I get some feedback, and if there are no objections, I'll move the rest of the code to use the enum instead of the string.

> Change Slice state into enum
> ----------------------------
>
>                 Key: SOLR-7325
>                 URL: https://issues.apache.org/jira/browse/SOLR-7325
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: Shai Erera
>         Attachments: SOLR-7325.patch
>
>
> Slice state is currently interacted with as a string. It is IMO not trivial to understand which values it can be compared to, in part because the Replica and Slice states are located in different classes, some repeating same constant names and values.
> Also, it's not very clear when does a Slice get into which state and what does that mean.
> I think if it's an enum, and documented briefly in the code, it would help interacting with it through code. I don't mind if we include more extensive documentation in the reference guide / wiki and refer people there for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org